This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Better loottable hooks #139
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only issue is: once again, the lambda is static, and that *doesn't work for this* because we need the lootManager to fire the event. I do have a couple ideas revolving around doing something hacky with JsonElement, and doing something hacky with ImmutableMap.Builder, but this is my current status.
|
Kit's taking a break from modding, if someone wants to take up this PR they can make PRs to this branch. |
|
I'm still around to answer questions and stuff though ^-^ EDIT: Right, it may worth looking at using Fabric's loot table event again -- we can't handle setting the names of loot pools with it, but that doesn't mean we can't still use it to obtain the final result |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this as a draft pull request so we can discuss.
I believe there's still an error present, but it's just a matter of how we handle an exception.
The whole idea is to cut out the static
ThreadLocal<Deque<...>>in LootHooks in favor of messing with json. However, this PR also includes a technique we could use to avoid overwriting the lambda that could be pulled in on its own. (see second commit)