Make userdev version be fetched dynamically #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
|
No idea what the format issue is. If somebody can tell me, please do so |
|
I'm not particularly fond of creating another component just for userdev, I'd much rather have it be a part of |
|
@zlataovce actually thinking about it, maybe I should put that util method into util/versionUtils.ts. Give me a second |
yes, it should be cached in an expiring value |
zlataovce
approved these changes
Oct 25, 2024
powercasgamer
suggested changes
Oct 25, 2024
powercasgamer
approved these changes
Oct 25, 2024
olijeffers0n
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hardcoding a version value or focing the user to fetch it itself (previous change to this site), it should just be fetched live.
I have no idea what I am doing, so suggest changes freely