feat: Add event to modify and/or block backend updates to the tablist #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… player Inspired by PaperMC#874
Timongcraft
changed the title
|
Since no suggestions/change requests were made on Discord or here, I'm gonna mark this as ready |
|
The current implementation is flawed and needs to be re-thought. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a concept implementation to allow plugins to modify the tablist that is sent by the backend server.
While it is completly functional, there are aspects I'm not quite fond about, for example that there's a bit of duplicate code now.
Please let me know if you think there's a better design that could be implemented!
Also, if you think the version-specific behavior should somehow be handled internally, please let me know.
Should fix #870
Inspired by #874