Support plugin message in configuration stage #1096
Conversation
| String brand = PluginMessageUtil.readBrandMessage(packet.content()); | ||
| server.getEventManager().fireAndForget(new PlayerClientBrandEvent(player, brand)); | ||
| player.setClientBrand(brand); | ||
| // Client sends `minecraft:brand` packet immediately after Login, |
There was a problem hiding this comment.
We should probably look into ensuring that this is at least sent somewhere if we can't just send it right now; I need to spend some time looking over this, ideally we should race hard to get the connection to the server into configuration so we can deal with syncing stuff, but, that is probably a wider headache to deal with someday (hopefully soon™)
There was a problem hiding this comment.
The client also won't send minecraft:brand when it re-enters the configuration stage after being connected, so I think it is safe to discard this packet.
In the design of Fabric-API, the client will only respond after receiving a packet from the server, so it should not lose any other packets.
|
Bump, would really like to see this fixed |
|
I too would like to see this fixed. |
|
@electronicboy Can it be merged at the current state? At least this allows 1.20.2 with FabricAPI to connect. Before this PR, the velocity would discard all PluginMessages, and the vanilla server didn't handle PluginMessages at all. So, I don't think this PR will break anything unless it's already broken. |
|
Would love to see this fixed as well. Waiting to start a small Minecraft server network for my friends and I and this is the last thing missing. |
Fabric-API will send PluginMessage in configuration stage and use PingIdentify to confirm the client is ready, so Velocity must transfer packets to the backend server.
Fix #1095