Bundle spark

[kashike]

discussion: #10565
docs: PaperMC/docs#447

New configuration options (global configuration):

spark:
  # If the bundled spark profiler should be enabled at all.
  enabled: true
  # If the bundled spark profiler should be enabled as soon as possible.
  # If true, spark enables as early as possible. This can be useful for profiling the server during startup.
  # If false, spark enables once the server has finished starting up (when the `Done (4.720s)! For help, type "help"` message is sent in console).
  enable-immediately: false
  # Prefers the spark plugin over the bundled spark profiler.
  # If enabled and the spark plugin is found in the plugins directory, it will be loaded and the bundled spark profiler will not be loaded.
  # If enabled and the spark plugin is not found in the plugins directory, the bundled profiler will be enabled.
  prefer-spark-plugin: false

[zlataovce]

remove timings patch as it's going to replaced with spark. i heard that it's now deprecated and marked for removal in paper.

it is deprecated and turned off by default now, but it shouldn't be removed entirely yet, since there are people which may still want to use it/need to use it

[Outfit8TSB]

remove timings patch as it's going to replaced with spark. i heard that it's now deprecated and marked for removal in paper.

disregard this comment, this is not gonna happen as this will turned off as default

[Leguan16]

Should also add a config option to disable spark.

[kennytv]

The We recommend installing the spark profiler as a replacement: warning in the timings patch needs updating

It also currently throws exceptions on stop (if you have any other plugin installed) due to a bukkit service being registered with a null plugin, presumably within spark

[Outfit8TSB]

I swear that this will lead to confusion as lucko/spark#424 didn't merge. If Spark keeps disabling after the update, it will get confused, This Pull was necessary to merge. As Spark will get disabled without warning.