Faster alerts fetching #314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsreynolds
requested changes
Oct 4, 2023
There was a problem hiding this comment.
Need to resolve merge conflict / preserve alert count fix change from #321
Comment on lines
-379
to
-388
| useEffect(() => { | ||
| if (inView) { | ||
| if (!row.original.alerts) { | ||
| getIncidentAlerts(row.original.id); | ||
| } | ||
| if (!row.original.notes) { | ||
| getIncidentNotes(row.original.id); | ||
| } | ||
| } | ||
| }, [inView]); |
There was a problem hiding this comment.
@martindstone - need to review this as the change we did to fix the alert count in #321 was implemented here in this useEffect, but it's removed in this PR. Is it handled elsewhere instead?
useEffect(() => {
if (inView) {
if (
!row.original.alerts
|| (Array.isArray(row.original.alerts) && row.original.alerts.length !== row.original.alert_counts?.all)
) {
getIncidentAlerts(row.original.id);
}
if (!row.original.notes) {
getIncidentNotes(row.original.id);
}
}
}, [inView]);
|
I am gonna make this a draft and rebase and fix some things... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the alerts and notes fetching to use the new endpoints implemented for PDlive. Notes and alerts fetching is much faster, and there is no longer any need for intersection observer or lazy loading, so a bunch of hacky stuff can be removed.