Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UCLA-1-0-1 source ID #164

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add UCLA-1-0-1 source ID #164

wants to merge 6 commits into from

Conversation

znichollscr
Copy link
Collaborator

@znichollscr znichollscr commented Dec 13, 2024

Description

Checklist

Please confirm that this pull request has done the following:

  • (N/A) Documentation added (where applicable)
  • Changelog item added to changelog/

@znichollscr
Copy link
Collaborator Author

@jfkok can you confirm you're happy with this please?

@znichollscr
Copy link
Collaborator Author

x-ref PCMDI/mip-cmor-tables#84

Copy link

No changes to the database between 'main' branch and 3a19f74

Copy link

No changes to the database between 'main' branch and 634f7dc

Copy link

No changes to the database between 'main' branch and bfa70e6

Copy link

Changes to the database between commit 170a42c and the 'main' branch

Summary table
count
source_id operation
UCLA-1-0-1 create 1
UCLA-1-0-1-constant create 1
UCLA-1-0-1-decreasing create 1
UCLA-1-0-1-increasing create 1
Overview
operation source_id,tracking_id
0 create UCLA-1-0-1-decreasing,None
1 create UCLA-1-0-1-constant,None
2 create UCLA-1-0-1-increasing,None
3 create UCLA-1-0-1,None
Overview, split by source ID
Source ID: UCLA-1-0-1
operation source_id,tracking_id source_id
3 create UCLA-1-0-1,None UCLA-1-0-1
Source ID: UCLA-1-0-1-constant
operation source_id,tracking_id source_id
1 create UCLA-1-0-1-constant,None UCLA-1-0-1-constant
Source ID: UCLA-1-0-1-decreasing
operation source_id,tracking_id source_id
0 create UCLA-1-0-1-decreasing,None UCLA-1-0-1-decreasing
Source ID: UCLA-1-0-1-increasing
operation source_id,tracking_id source_id
2 create UCLA-1-0-1-increasing,None UCLA-1-0-1-increasing
Detailed changes, split by source ID
Source ID: UCLA-1-0-1
Created entry for tracking ID: None Entry:
{
    "Conventions": null,
    "activity_id": "input4MIPs",
    "comment": null,
    "comment_post_publication": null,
    "contact": "[email protected]",
    "creation_date": null,
    "data_node": null,
    "dataset_category": null,
    "datetime_end": null,
    "datetime_start": null,
    "doi": null,
    "esgf_dataset_master_id": null,
    "filepath": null,
    "frequency": null,
    "further_info_url": "http://www.tbd.invalid",
    "grid": null,
    "grid_label": null,
    "institution": null,
    "institution_id": "UCLA",
    "latest": null,
    "license": null,
    "license_id": "CC BY 4.0",
    "mip_era": "CMIP6Plus",
    "nominal_resolution": null,
    "product": null,
    "publication_status": "registered",
    "realm": null,
    "references": null,
    "region": null,
    "replica": null,
    "sha256": null,
    "source": null,
    "source_id": "UCLA-1-0-1",
    "source_version": "1.0.1",
    "target_mip": null,
    "time_range": null,
    "timestamp": null,
    "tracking_id": null,
    "validated_input4mips": null,
    "variable_id": null,
    "version": null,
    "xlink": null
}
Source ID: UCLA-1-0-1-constant
Created entry for tracking ID: None Entry:
{
    "Conventions": null,
    "activity_id": "input4MIPs",
    "comment": null,
    "comment_post_publication": null,
    "contact": "[email protected]",
    "creation_date": null,
    "data_node": null,
    "dataset_category": null,
    "datetime_end": null,
    "datetime_start": null,
    "doi": null,
    "esgf_dataset_master_id": null,
    "filepath": null,
    "frequency": null,
    "further_info_url": "http://www.tbd.invalid",
    "grid": null,
    "grid_label": null,
    "institution": null,
    "institution_id": "UCLA",
    "latest": null,
    "license": null,
    "license_id": "CC BY 4.0",
    "mip_era": "CMIP6Plus",
    "nominal_resolution": null,
    "product": null,
    "publication_status": "registered",
    "realm": null,
    "references": null,
    "region": null,
    "replica": null,
    "sha256": null,
    "source": null,
    "source_id": "UCLA-1-0-1-constant",
    "source_version": "1.0.1",
    "target_mip": null,
    "time_range": null,
    "timestamp": null,
    "tracking_id": null,
    "validated_input4mips": null,
    "variable_id": null,
    "version": null,
    "xlink": null
}
Source ID: UCLA-1-0-1-decreasing
Created entry for tracking ID: None Entry:
{
    "Conventions": null,
    "activity_id": "input4MIPs",
    "comment": null,
    "comment_post_publication": null,
    "contact": "[email protected]",
    "creation_date": null,
    "data_node": null,
    "dataset_category": null,
    "datetime_end": null,
    "datetime_start": null,
    "doi": null,
    "esgf_dataset_master_id": null,
    "filepath": null,
    "frequency": null,
    "further_info_url": "http://www.tbd.invalid",
    "grid": null,
    "grid_label": null,
    "institution": null,
    "institution_id": "UCLA",
    "latest": null,
    "license": null,
    "license_id": "CC BY 4.0",
    "mip_era": "CMIP6Plus",
    "nominal_resolution": null,
    "product": null,
    "publication_status": "registered",
    "realm": null,
    "references": null,
    "region": null,
    "replica": null,
    "sha256": null,
    "source": null,
    "source_id": "UCLA-1-0-1-decreasing",
    "source_version": "1.0.1",
    "target_mip": null,
    "time_range": null,
    "timestamp": null,
    "tracking_id": null,
    "validated_input4mips": null,
    "variable_id": null,
    "version": null,
    "xlink": null
}
Source ID: UCLA-1-0-1-increasing
Created entry for tracking ID: None Entry:
{
    "Conventions": null,
    "activity_id": "input4MIPs",
    "comment": null,
    "comment_post_publication": null,
    "contact": "[email protected]",
    "creation_date": null,
    "data_node": null,
    "dataset_category": null,
    "datetime_end": null,
    "datetime_start": null,
    "doi": null,
    "esgf_dataset_master_id": null,
    "filepath": null,
    "frequency": null,
    "further_info_url": "http://www.tbd.invalid",
    "grid": null,
    "grid_label": null,
    "institution": null,
    "institution_id": "UCLA",
    "latest": null,
    "license": null,
    "license_id": "CC BY 4.0",
    "mip_era": "CMIP6Plus",
    "nominal_resolution": null,
    "product": null,
    "publication_status": "registered",
    "realm": null,
    "references": null,
    "region": null,
    "replica": null,
    "sha256": null,
    "source": null,
    "source_id": "UCLA-1-0-1-increasing",
    "source_version": "1.0.1",
    "target_mip": null,
    "time_range": null,
    "timestamp": null,
    "tracking_id": null,
    "validated_input4mips": null,
    "variable_id": null,
    "version": null,
    "xlink": null
}

@znichollscr znichollscr requested a review from durack1 December 13, 2024 10:21
Copy link
Contributor

@durack1 durack1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@znichollscr this looks good to me, I do wonder about whether having a separate source_id for each "scenario" is a good idea, but I think this is the cleanest and easiest way to get stuff done quickly.. What target_mip do we want to identify here - AerChemMIP2? That is what we have identified at https://wcrp-cmip.org/mips/aerchemmip2/ and https://wcrp-cmip.org/mips/#registered_mips

@znichollscr
Copy link
Collaborator Author

znichollscr commented Dec 19, 2024

@znichollscr this looks good to me, I do wonder about whether having a separate source_id for each "scenario" is a good idea, but I think this is the cleanest and easiest way to get stuff done quickly

Yes and the way it was done in CMIP6. As you say, other solutions aren't obvious and we should approach them more slowly (x-ref #64).

What target_mip do we want to identify here - AerChemMIP2?

Ah yes, probably a good question for @jfkok. Is AerChemMIP2 the right target MIP?

@jfkok
Copy link

jfkok commented Dec 19, 2024

Yes, AerChemMIP2 is the correct target MIP - thanks for checking. And the UCLA source ID and institution ID look good to me, thanks.

@znichollscr
Copy link
Collaborator Author

Perfect. I think if you follow the instructions in this comment (#140 (comment)), then we'll be good to go

@znichollscr
Copy link
Collaborator Author

@durack1 we can either merge this now, then update once we have data. Or we can just let this sit until we have data. I don't mind either way, but it might be easier for you to see how this all fits together if we wait (because, that way, there won't be all these null values for target_mip and other things that often cause confusion)

@jfkok
Copy link

jfkok commented Dec 19, 2024 via email

@durack1
Copy link
Contributor

durack1 commented Dec 19, 2024

Early 2025 works well for me, I don't believe this is holding anything up, now, so circling back and cleaning up some loose ends will be useful - January 2025, @jfkok ping this thread when you're back online - have a great xmas break!

@jfkok
Copy link

jfkok commented Dec 19, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants