Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the documentation for simplicity #19

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

Sanjay8602
Copy link

Nothing just added the documentation for simplicity and easy to understand

@Sanjay8602
Copy link
Author

@OscarArroyoVega have a look

Copy link
Owner

@OscarArroyoVega OscarArroyoVega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Sanjay,Thank you! if you take a look to unifyai style (also in dspy) they don't add "Args" to the docstring, just a single line description.
Just remove the "args" for approval :)

@Sanjay8602
Copy link
Author

Sanjay8602 commented Jul 16, 2024 via email

Copy link
Author

@Sanjay8602 Sanjay8602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now looks similar. I added the "args" and now deleted

Copy link
Owner

@OscarArroyoVega OscarArroyoVega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!!

@OscarArroyoVega OscarArroyoVega merged commit 22f4493 into OscarArroyoVega:main Jul 16, 2024
4 of 5 checks passed
@Sanjay8602 Sanjay8602 deleted the UnifyLLM branch July 16, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants