Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

651 - Change app bar management #667

Merged
merged 24 commits into from
Oct 24, 2023
Merged

651 - Change app bar management #667

merged 24 commits into from
Oct 24, 2023

Conversation

paulinea
Copy link
Member

No description provided.

@paulinea paulinea linked an issue Oct 17, 2023 that may be closed by this pull request
Change TopAppBar management (title, actions,...) #651
Closed
@netlify
Copy link

netlify bot commented Oct 17, 2023 •
edited
Loading

✅ Deploy Preview for ods-android ready!

Name Link
🔨 Latest commit ffbf445
🔍 Latest deploy log https://app.netlify.com/sites/ods-android/deploys/6537f1a757d92000070af2df
😎 Deploy Preview https://deploy-preview-667--ods-android.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@paulinea paulinea force-pushed the 651-change-topappbar-management branch from e579cab to e42f3fb Compare October 17, 2023 14:57
@paulinea paulinea marked this pull request as ready for review October 17, 2023 15:35
florentmaitre
florentmaitre reviewed Oct 23, 2023
View reviewed changes
app/src/main/java/com/orange/ods/app/ui/AppBar.kt Outdated Show resolved Hide resolved
app/src/main/java/com/orange/ods/app/ui/AppBarActions.kt Outdated Show resolved Hide resolved
app/src/main/java/com/orange/ods/app/ui/AppBarActions.kt Outdated Show resolved Hide resolved
app/src/main/java/com/orange/ods/app/ui/AppBarActions.kt Outdated Show resolved Hide resolved
app/src/main/java/com/orange/ods/app/ui/AppBarState.kt Outdated Show resolved Hide resolved
app/src/main/java/com/orange/ods/app/ui/AppBarActions.kt Outdated Show resolved Hide resolved
app/src/main/java/com/orange/ods/app/ui/Screen.kt Outdated Show resolved Hide resolved
app/src/main/java/com/orange/ods/app/ui/Screen.kt Outdated Show resolved Hide resolved
app/src/main/java/com/orange/ods/app/ui/components/Component.kt Show resolved Hide resolved
app/src/main/java/com/orange/ods/app/ui/components/appbars/top/ComponentTopAppBar.kt Outdated Show resolved Hide resolved
paulinea added 24 commits October 24, 2023 18:30
@paulinea @florentmaitre
[#651] Implement a new way to manage top app bar
e4804bb
@paulinea @florentmaitre
[#651] Rename some files and methods
174ee1f
@paulinea @florentmaitre
[#651] Update changelog
948cb0a
@paulinea @florentmaitre
[#651] Add documentation
01e93fb
@paulinea @florentmaitre
[#651] Review: Compute navigationIcon in AppBarState
7357193
@paulinea @florentmaitre
[#651] Review: Rename getOdsTopAppBarActionButton by getOdsTopAppBarA…
df7bf08 
…ction
@paulinea @florentmaitre
[#651] Review: Rename method
2740188
@paulinea @florentmaitre
[#651] Review: Hoist searchedText state in AppBarState
7a24d60
@paulinea @florentmaitre
[#651] Review: Move alwaysVisibleAction in AppBarAction companion
46a127b
@paulinea @florentmaitre
[#651] Review: Rename value
18f26d9
@paulinea @florentmaitre
[#651] Review: Move line in if statement
75f310a
@paulinea @florentmaitre
[#651] Review: Add remember keys for AppBarState
5fc6a68
@paulinea @florentmaitre
[#651] Review: Remove navigation around bottom bar graph in AppNavGraph
95c518a
@paulinea @florentmaitre
[#651] Review: Rename MainDestinations in MainNavigation
8893f6e
@paulinea @florentmaitre
[#651] Review: Replace showTabs by its value directly
497b7f4
@paulinea @florentmaitre
[#651] Review: Rename private methods
0d10e27
@paulinea @florentmaitre
[#651] Review: Simplify expression
15dde8a
@paulinea @florentmaitre
[#651] Review: Set route parameter as non nullable in getScreen method
102527c
@paulinea @florentmaitre
[#651] Review: Rename alwaysVisibleActions into defaultActions
8a9ef3b
@paulinea @florentmaitre
[#651] Review: Remove overflow menu actions from Screen cause it's on…
14af604 
…ly use in the case of a custom config
@paulinea @florentmaitre
[#651] Review: Replace ScreenType by Screen properties
6adcf10
@paulinea @florentmaitre
[#651] Review: Set componentId and variantId parameters non nullable
8a458c8
@paulinea @florentmaitre
[#651] Review: Rename titleRes property of AppBarConfiguration by lar…
c7e84fb 
…geTitleRes
@paulinea @florentmaitre
[#651] Review: Simplify expression
ffbf445
@florentmaitre florentmaitre force-pushed the 651-change-topappbar-management branch from 3edc8d6 to ffbf445 Compare October 24, 2023 16:32
@florentmaitre florentmaitre merged commit a819a1d into develop Oct 24, 2023
7 checks passed
@florentmaitre florentmaitre deleted the 651-change-topappbar-management branch October 24, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florentmaitre florentmaitre florentmaitre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change TopAppBar management (title, actions,...)
2 participants
@paulinea @florentmaitre