Resolve vulnerable dependencies #77
Conversation
There was a problem hiding this comment.
this module was created by John if you needed to update/maintain it directly https://www.npmjs.com/package/fs-json
There was a problem hiding this comment.
Yeah, I know. I didn't want to update upstream at this time.
| const { home } = require('../controller/env'); | ||
| const os = require('node:os'); | ||
| const path = require('path'); | ||
| /* global describe it before afterEach */ | ||
| require('mocha'); | ||
| require('should'); |
There was a problem hiding this comment.
are these requires necessary?
require('mocha');
require('should');There was a problem hiding this comment.
I'm not sure. I made (or will make) an issue to update Mocha. I started it on this PR but it broke everything, so I reverted for now.
There was a problem hiding this comment.
for sure. I'm pretty sure when you run the tests with mocha, that mocha exists in the global scope. It may be that these are meant to be run for projects (within the tool) and not the tests for the tool.. you could probably answer that more clearly, since you've been poking around the tool
| @@ -40,8 +22,6 @@ const test = proxyquire('../controller/test', { | |||
| } | |||
| }); | |||
| const projectsDirectory = './test/files/environment/projects'; | |||
There was a problem hiding this comment.
should the path module be used here?
|
|
||
| /** | ||
| * | ||
| * @param {{ session: *, projectAction: string}} param0 |
There was a problem hiding this comment.
is the * interpreted as any?
| projects.action = () => 'shelve'; | ||
| projects.action = 'shelve'; |
There was a problem hiding this comment.
was this being invoked somewhere?
There was a problem hiding this comment.
I put it back. It was changed for a type error caused by this code. It's fixed now
TODO:
minimist/mkdirp