Merge pull request #57 from OperationSpark/debug-url

Update deps

.github/workflows/check-dist.yml

@@ -34,9 +34,9 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Setup Node.js
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
           cache: npm
 
       - name: Install Dependencies

.github/workflows/ci.yml

@@ -19,9 +19,9 @@ jobs:
 
       - name: Setup Node.js
         id: setup-node
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
           cache: npm
 
       - name: Install Dependencies
@@ -40,25 +40,25 @@ jobs:
         id: npm-ci-test
         run: npm run ci-test
 
-  test-action:
-    name: GitHub Actions Test
-    runs-on: ubuntu-latest
+  # test-action:
+  #   name: GitHub Actions Test
+  #   runs-on: ubuntu-latest
 
-    steps:
-      - name: Checkout
-        id: checkout
-        uses: actions/checkout@v4
+  #   steps:
+  #     - name: Checkout
+  #       id: checkout
+  #       uses: actions/checkout@v4
 
-      - name: Test Local Action
-        id: test-action
-        uses: ./
-        with:
-          subject: 'github.actions.test'
-          message: '{"action": "action-nats-publish"}'
-          urls: tls://connect.ngs.global
-          jwt: ${{ secrets.NATS_CLIENT_JWT }}
-          nKeySeed: ${{ secrets.NATS_NKEY_SEED }}
+  #     - name: Test Local Action
+  #       id: test-action
+  #       uses: ./
+  #       with:
+  #         subject: 'github.actions.test'
+  #         message: '{"action": "action-nats-publish"}'
+  #         urls: tls://connect.ngs.global
+  #         jwt: ${{ secrets.NATS_CLIENT_JWT }}
+  #         nKeySeed: ${{ secrets.NATS_NKEY_SEED }}
 
-      - name: Print Output
-        id: output
-        run: echo "${{ steps.test-action.outputs.published }}"
+  #     - name: Print Output
+  #       id: output
+  #       run: echo "${{ steps.test-action.outputs.published }}"

.github/workflows/linter.yml

@@ -25,9 +25,9 @@ jobs:
 
       - name: Setup Node.js
         id: setup-node
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
           cache: npm
 
       - name: Install Dependencies

__tests__/main.test.ts

@@ -13,7 +13,7 @@ import * as main from '../src/main'
 // Mock the GitHub Actions core library
 const debugMock = jest.spyOn(core, 'debug')
 const getInputMock = jest.spyOn(core, 'getInput')
-// const setFailedMock = jest.spyOn(core, 'setFailed')
+const setFailedMock = jest.spyOn(core, 'setFailed')
 const setOutputMock = jest.spyOn(core, 'setOutput')
 
 // Mock the action's main function
@@ -31,7 +31,7 @@ describe('action', () => {
     urls: 'nats://localhost:4222',
     message: '{"test": 1234}',
     nKeySeed: 'SNOTAREALNKEYSEED',
-    jwt: 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiaWF0IjoxNTE2MjM5MDIyfQ.SflKxwRJSMeKKF2QT4fwpMeJf36POk6yJV_adQssw5c'
+    jwt: 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiaWF0IjoxNTE2MjM5MDIyfQ.SflKxwRJSMeKKF2QT4fwpMeJf36POk6yJV_adQssw5c' // gitleaks:allow
   }
 
   it('Connects to NATS', async () => {
@@ -74,6 +74,10 @@ describe('action', () => {
     // Verify that all of the core library functions were called correctly
     expect(debugMock).toHaveBeenNthCalledWith(
       1,
+      'connecting to:\nnats://localhost:4222'
+    )
+    expect(debugMock).toHaveBeenNthCalledWith(
+      2,
       `NATS connected to nats://localhost:4222`
     )
     expect(setOutputMock).toHaveBeenNthCalledWith(
@@ -82,4 +86,42 @@ describe('action', () => {
       `subject: subject.test, message: {"test": 1234}`
     )
   })
+
+  it('Fails when a connection error occurs', async () => {
+    // Mock the NATS connection
+    const mockConnectImpl = async (): Promise<nats.NatsConnection> => {
+      throw new Error('Invalid URL')
+    }
+
+    connectMock.mockImplementation(mockConnectImpl)
+
+    await main.run()
+    expect(runMock).toHaveReturned()
+
+    expect(setFailedMock).toHaveBeenNthCalledWith(1, 'Invalid URL')
+  })
+
+  it('Fails when a connection close error occurs', async () => {
+    // Mock the NATS connection
+    const mockConnectImpl = async (): Promise<nats.NatsConnection> => {
+      return {
+        info: { server_name: 'nats://localhost:4222' },
+        publish: jest.fn(),
+        close: jest.fn(),
+        // Yes, closed() returns an Error rather than throwing one
+        closed: async () => new Error('connection already closed'),
+        drain: jest.fn()
+      } as unknown as nats.NatsConnection
+    }
+
+    connectMock.mockImplementation(mockConnectImpl)
+
+    await main.run()
+    expect(runMock).toHaveReturned()
+
+    expect(debugMock).toHaveBeenNthCalledWith(
+      5,
+      'error closing:\nconnection already closed'
+    )
+  })
 })

package.json

@@ -1,16 +1,16 @@
 {
-  "name": "typescript-action",
-  "description": "GitHub Actions TypeScript template",
-  "version": "0.0.1-0",
-  "author": "",
+  "name": "action-nats-publish",
+  "description": "Publish a message to NATS servers",
+  "version": "0.0.2-0",
+  "author": "OperationSpark",
   "private": true,
-  "homepage": "https://github.com/actions/typescript-action",
+  "homepage": "https://github.com/OperationSpark/action-nats-publish",
   "repository": {
     "type": "git",
-    "url": "git+https://github.com/actions/typescript-action.git"
+    "url": "git+https://github.com/OperationSpark/action-nats-publish.git"
   },
   "bugs": {
-    "url": "https://github.com/actions/typescript-action/issues"
+    "url": "https://github.com/OperationSpark/action-nats-publish/issues"
   },
   "keywords": [
     "actions",