-
-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Adding game save/load callbacks for lua scripting. #1395
Conversation
12cfe1e
to
791ad8a
Compare
791ad8a
to
574a5a1
Compare
Sorry! This feature will be merged as a part of the Call of Chernobyl code merge, but with CoC/Anomaly matching callback names. |
Is there any WIP branch / fork? |
Not yet, I screwed some changes and discarded the branch (but saved the already finished work luckily) yesterday. I will start again somewhat soon. There's not much changes really. |
Sounds good. Do we expect CoC to work out of box with OXR engine + their gamedata? |
Yes, but it's the same as for other mods – there might be errors in scripts which are ok for luabind used in vanilla engine (and CoC engine), but our luabind may not tolerate them.
|
CoC support can be tracked in #1529. |
@Xottab-DUTY |
Adding optional lua callbacks to allow creation of custom saves.
Following same pattern as CoC/anomaly mods. Having
marshal
library without these callbacks does not make complete sense because NetPacket has size limitations and requires strict data ordering.Changes:
on_before_game_save
lua callbackon_game_save
lua callbackon_before_game_load
lua callbackon_game_load
lua callback