Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: template editor edit sync action for issue#309 #347

Closed
wants to merge 1,158 commits into from

Conversation

ClodLingxi
Copy link
Contributor

@ClodLingxi ClodLingxi commented Nov 28, 2024

tinyAdapter and others added 30 commits April 26, 2024 15:58
feat: Language Server Protocol functionalities
Former-commit-id: 9ed8883
Former-commit-id: 054678c
Former-commit-id: af2ce93
rename auto selection

Former-commit-id: 30a5eaf
Basic WebGAL Language Service

Former-commit-id: 14d19e3
add template folder info on assets

Former-commit-id: 9a52611
Former-commit-id: 0b85cf8
improve display of the delete dialog, fix nested folder scene file editing

Former-commit-id: ef9d700
Former-commit-id: d3bf514
Former-commit-id: b7d7c5b
feat: add live preview button on game preview
Former-commit-id: 3fb41d4
Former-commit-id: 6661351
@MakinoharaShoko MakinoharaShoko changed the base branch from main to dev December 1, 2024 13:22
@MakinoharaShoko MakinoharaShoko self-requested a review December 1, 2024 13:22
@@ -1,8 +1,73 @@
import {logger} from "./logger";
import {DebugCommand, IDebugMessage} from "@/types/debugProtocol";
import useEditorStore from "@/store/useEditorStore";
import {isArray} from "lodash";

export interface componentsVisibility {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interface 命名不规范

const compose = (message: componentVisibilityCommandInterface[]) => {
return message.map((item) => {
return `${item.component}:${item.visibility}`;
}).join('\n');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1、这里直接序列化,引擎那边反序列化是不是比这种手动序列化来的更方便,还不容易出问题
2、引擎侧看起来是 split ; ,这里为何是 join \n

* 不知道为啥,不写到这打包会有问题
*/
const textbox = {
export const TemplateGraphicComponentTreeTitle = () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

函数命名不符合规范

@MakinoharaShoko MakinoharaShoko force-pushed the dev branch 2 times, most recently from 0c2fdbd to be4e2c7 Compare December 20, 2024 16:52
@ClodLingxi ClodLingxi closed this Dec 21, 2024
@ClodLingxi ClodLingxi deleted the temperal-graphic-#309 branch December 25, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants