Update precondition implementation

OpenSwiftUIProject · Nov 24, 2024 · c7af959 · c7af959
1 parent 5954bc7
commit c7af959
Show file tree

Hide file tree

Showing 91 changed files with 316 additions and 308 deletions.
diff --git a/Package.swift b/Package.swift
@@ -17,13 +17,21 @@ func envEnable(_ key: String, default defaultValue: Bool = false) -> Bool {
     }
 }
 
-let isXcodeEnv = Context.environment["__CFBundleIdentifier"] == "com.apple.dt.Xcode"
-let development = envEnable("OPENSWIFTUI_DEVELOPMENT", default: false)
-
-// Xcode use clang as linker which supports "-iframework" while SwiftPM use swiftc as linker which supports "-Fsystem"
-let systemFrameworkSearchFlag = isXcodeEnv ? "-iframework" : "-Fsystem"
+var sharedSwiftSettings: [SwiftSetting] = [
+    .enableUpcomingFeature("BareSlashRegexLiterals"),
+    .enableUpcomingFeature("InternalImportsByDefault"),
+    .define("OPENSWIFTUI_SUPPRESS_DEPRECATED_WARNINGS"),
+    .swiftLanguageMode(.v5),
+]
 
 let releaseVersion = Context.environment["OPENSWIFTUI_TARGET_RELEASE"].flatMap { Int($0) } ?? 2024
+sharedSwiftSettings.append(.define("OPENSWIFTUI_RELEASE_\(releaseVersion)"))
+if releaseVersion >= 2021 {
+    for year in 2021 ... releaseVersion {
+        sharedSwiftSettings.append(.define("OPENSWIFTUI_SUPPORT_\(year)_API"))
+    }
+}
+
 let platforms: [SupportedPlatform] = switch releaseVersion {
 case 2024: // iOS 18.0
     [
@@ -53,18 +61,15 @@ default:
     ]
 }
 
-var sharedSwiftSettings: [SwiftSetting] = [
-    .enableUpcomingFeature("BareSlashRegexLiterals"),
-    .enableUpcomingFeature("InternalImportsByDefault"),
-    .define("OPENSWIFTUI_SUPPRESS_DEPRECATED_WARNINGS"),
-    .define("OPENSWIFTUI_RELEASE_\(releaseVersion)"),
-    .swiftLanguageMode(.v5),
-]
+let isXcodeEnv = Context.environment["__CFBundleIdentifier"] == "com.apple.dt.Xcode"
 
-if releaseVersion >= 2021 {
-    for year in 2021 ... releaseVersion {
-        sharedSwiftSettings.append(.define("OPENSWIFTUI_SUPPORT_\(year)_API"))
-    }
+// Xcode use clang as linker which supports "-iframework" while SwiftPM use swiftc as linker which supports "-Fsystem"
+let systemFrameworkSearchFlag = isXcodeEnv ? "-iframework" : "-Fsystem"
+
+let development = envEnable("OPENSWIFTUI_DEVELOPMENT")
+
+if development {
+    sharedSwiftSettings.append(.define("OPENSWIFTUI_DEVELOPMENT"))
 }
 
 let warningsAsErrorsCondition = envEnable("OPENSWIFTUI_WERROR", default: isXcodeEnv && development)

diff --git a/Sources/OpenSwiftUI/Accessibility/Modifier/internal/AccessibilityConfigurationModifier.swift b/Sources/OpenSwiftUI/Accessibility/Modifier/internal/AccessibilityConfigurationModifier.swift
@@ -15,5 +15,5 @@ protocol AccessibilityConfigurationModifier {
 }
 
 extension AccessibilityConfigurationModifier where Configuration == Never {
-    var configuration: Configuration { fatalError() }
+    var configuration: Configuration { preconditionFailure("") }
 }
diff --git a/Sources/OpenSwiftUI/App/FinishLaunchTestAction.swift b/Sources/OpenSwiftUI/App/FinishLaunchTestAction.swift
@@ -17,7 +17,7 @@ struct FinishLaunchTestAction {
         #if os(iOS)
         UIApplication.shared.finishedTest(UIApplication.shared._launchTestName())
         #else
-        fatalError("Unimplemented for other platform")
+        preconditionFailure("Unimplemented for other platform")
         #endif
     }
 }

diff --git a/Sources/OpenSwiftUI/App/LegacyApp.swift b/Sources/OpenSwiftUI/App/LegacyApp.swift
@@ -19,7 +19,7 @@ extension __App {
         var rootView: V
 
         init() {
-            fatalError("Not a standalone App.")
+            preconditionFailure("Not a standalone App.")
         }
 
         init(rootView: V) {

diff --git a/Sources/OpenSwiftUI/App/OpenSwiftUIApplication.swift b/Sources/OpenSwiftUI/App/OpenSwiftUIApplication.swift
@@ -25,7 +25,7 @@ private final class OpenSwiftUIApplication: NSApplication {
     }
 
     required init?(coder: NSCoder) {
-        fatalError("init(coder:) has not been implemented")
+        preconditionFailure("init(coder:) has not been implemented")
     }
 }
 #else

diff --git a/Sources/OpenSwiftUI/Core/Modifier/SceneModifier/TODO/_SceneModifier.swift b/Sources/OpenSwiftUI/Core/Modifier/SceneModifier/TODO/_SceneModifier.swift
@@ -22,6 +22,6 @@ extension _SceneModifier {
 extension _SceneModifier where Body == Never {
     @inline(__always)
     public func body(content _: SceneContent) -> Body {
-        fatalError("body() should not be called on \(Self.self)")
+        preconditionFailure("body() should not be called on \(Self.self)")
     }
 }
diff --git a/Sources/OpenSwiftUI/Core/Render/DisplayLink.swift b/Sources/OpenSwiftUI/Core/Render/DisplayLink.swift
@@ -28,11 +28,11 @@ final class DisplayLink: NSObject {
 
     #if os(iOS)
     init(host: AnyUIHostingView, window: UIWindow) {
-        fatalError("TODO")
+        preconditionFailure("TODO")
     }
     #elseif os(macOS)
     init(host: AnyUIHostingView, window: NSWindow) {
-        fatalError("TODO")
+        preconditionFailure("TODO")
     }
     #endif
 

diff --git a/Sources/OpenSwiftUI/EventHandling/Focus/FocusStoreLocation.swift b/Sources/OpenSwiftUI/EventHandling/Focus/FocusStoreLocation.swift
@@ -11,16 +11,16 @@ class FocusStoreLocation<A: Hashable>: AnyLocation<A>, @unchecked Sendable {
     }
 
     override func get() -> A {
-        fatalError("TODO")
+        preconditionFailure("TODO")
     }
 
     override func set(_ value: A, transaction: Transaction) {
-        fatalError("TODO")
+        preconditionFailure("TODO")
     }
 
     typealias Value = A
 
-    override init() { fatalError() }
+    override init() { preconditionFailure("") }
 
     var store: FocusStore
     weak var host: GraphHost?

diff --git a/Sources/OpenSwiftUI/Integration/Representable/UIKit/UIViewRepresentable.swift b/Sources/OpenSwiftUI/Integration/Representable/UIKit/UIViewRepresentable.swift
@@ -185,11 +185,11 @@ extension UIViewRepresentable {
     static func _modifyBridgedViewInputs(_ inputs: inout _ViewInputs) {}
 
     public static func _makeView(view: _GraphValue<Self>, inputs: _ViewInputs) -> _ViewOutputs {
-        fatalError("TODO")
+        preconditionFailure("TODO")
     }
 
     public static func _makeViewList(view: _GraphValue<Self>, inputs: _ViewListInputs) -> _ViewListOutputs {
-        fatalError("TODO")
+        preconditionFailure("TODO")
     }
 }
 

diff --git a/Sources/OpenSwiftUI/Integration/UIKit/UIHostingController.swift b/Sources/OpenSwiftUI/Integration/UIKit/UIHostingController.swift
@@ -28,7 +28,7 @@ open class UIHostingController<Content> : UIViewController where Content : View
     }
 
     public required init?(coder: NSCoder) {
-        fatalError("init(coder:) must be implemented in a subclass and call super.init(coder:, rootView:)")
+        preconditionFailure("init(coder:) must be implemented in a subclass and call super.init(coder:, rootView:)")
     }
 
     func _commonInit() {

diff --git a/Sources/OpenSwiftUI/Integration/UIKit/UIHostingView.swift b/Sources/OpenSwiftUI/Integration/UIKit/UIHostingView.swift
@@ -41,7 +41,7 @@ open class _UIHostingView<Content>: UIView where Content: View {
 
     @available(*, unavailable)
     public required init?(coder _: NSCoder) {
-        fatalError("init(coder:) has not been implemented")
+        preconditionFailure("init(coder:) has not been implemented")
     }
 
     deinit {
@@ -156,40 +156,40 @@ open class _UIHostingView<Content>: UIView where Content: View {
 extension _UIHostingView: ViewRendererHost {
     package var renderingPhase: OpenSwiftUICore.ViewRenderingPhase {
         get {
-            fatalError("TODO")
+            preconditionFailure("TODO")
         }
         set(newValue) {
-            fatalError("TODO")
+            preconditionFailure("TODO")
         }
     }
 
     package var externalUpdateCount: Int {
         get {
-            fatalError("TODO")
+            preconditionFailure("TODO")
         }
         set(newValue) {
-            fatalError("TODO")
+            preconditionFailure("TODO")
         }
     }
 
     package func updateEnvironment() {
-        fatalError("TODO")
+        preconditionFailure("TODO")
     }
 
     package func updateSize() {
-        fatalError("TODO")
+        preconditionFailure("TODO")
     }
 
     package func updateSafeArea() {
-        fatalError("TODO")
+        preconditionFailure("TODO")
     }
 
     package func updateScrollableContainerSize() {
-        fatalError("TODO")
+        preconditionFailure("TODO")
     }
 
     package func renderDisplayList(_ list: DisplayList, asynchronously: Bool, time: Time, nextTime: Time, targetTimestamp: Time?, version: DisplayList.Version, maxVersion: DisplayList.Version) -> Time {
-        fatalError("TODO")
+        preconditionFailure("TODO")
     }
 
     package func addImplicitPropertiesNeedingUpdate(to _: inout ViewRendererHostProperties) {}
@@ -216,7 +216,7 @@ extension _UIHostingView: ViewRendererHost {
     }
 
     package func rootTransform() -> ViewTransform {
-        fatalError("TODO")
+        preconditionFailure("TODO")
     }
 
     public func graphDidChange() {

diff --git a/Sources/OpenSwiftUI/Scene/Core/Scene.swift b/Sources/OpenSwiftUI/Scene/Core/Scene.swift
@@ -16,6 +16,6 @@ extension Never: Scene {}
 
 extension Scene {
     func sceneBodyError() -> Never {
-        fatalError("body() should not be called on \(Self.self)")
+        preconditionFailure("body() should not be called on \(Self.self)")
     }
 }
diff --git a/Sources/OpenSwiftUI/Scene/Core/SceneBuilder.swift b/Sources/OpenSwiftUI/Scene/Core/SceneBuilder.swift
@@ -44,7 +44,7 @@ extension SceneBuilder {
 //        if #available(iOS 16.1, macOS 13.0, watchOS 9.1, tvOS 16.1, *) {
 //            return LimitedAvailabilityScene(scene)
 //        } else {
-//            fatalError("Unavailable")
+//            preconditionFailure("Unavailable")
 //        }
 //    }
 }

diff --git a/Sources/OpenSwiftUI/Scene/WindowGroup.swift b/Sources/OpenSwiftUI/Scene/WindowGroup.swift
@@ -47,7 +47,7 @@ public struct WindowGroup<Content>: Scene where Content: View {
 
     // FIXME
     public var body: some Scene {
-        fatalError()
+        preconditionFailure("")
     }
 
     var title: Text?

diff --git a/Sources/OpenSwiftUI/Test/TestApp.swift b/Sources/OpenSwiftUI/Test/TestApp.swift
@@ -8,10 +8,10 @@
 
 public struct _TestApp {
     public init() {
-        fatalError("TODO")
+        preconditionFailure("TODO")
     }
     public func run() -> Never {
-        fatalError("TODO")
+        preconditionFailure("TODO")
     }
 }
 
@@ -21,12 +21,12 @@ extension _TestApp {
         var state: StateType
 
         init() {
-            fatalError("TODO")
+            preconditionFailure("TODO")
         }
 
         var body: some View {
             state.testView
-            fatalError("TODO")
+            preconditionFailure("TODO")
         }
     }
 

diff --git a/Sources/OpenSwiftUI/Test/TestIDView.swift b/Sources/OpenSwiftUI/Test/TestIDView.swift
@@ -19,7 +19,7 @@ struct TestIDView<Content, ID>: PrimitiveView, UnaryView {
 
     static func _makeView(view: _GraphValue<TestIDView<Content, ID>>, inputs: _ViewInputs) -> _ViewOutputs {
         // Use IdentifiedView here
-        fatalError("TODO")
+        preconditionFailure("TODO")
     }
 }
 

diff --git a/Sources/OpenSwiftUI/Test/_Benchmark.swift b/Sources/OpenSwiftUI/Test/_Benchmark.swift
@@ -5,6 +5,6 @@ public protocol _Benchmark: _Test {
 extension _TestApp {
     public func runBenchmarks(_ benchmarks: [_Benchmark]) -> Never {
         let _ = RootView()
-        fatalError("TODO")
+        preconditionFailure("TODO")
     }
 }
diff --git a/Sources/OpenSwiftUI/Test/_BenchmarkHost.swift b/Sources/OpenSwiftUI/Test/_BenchmarkHost.swift
@@ -42,7 +42,7 @@ extension _BenchmarkHost {
         }
         return end - begin
         #else
-        fatalError("Unsupported Platfrom")
+        preconditionFailure("Unsupported Platfrom")
         #endif
     }
 

diff --git a/Sources/OpenSwiftUI/Test/_PerformanceTest.swift b/Sources/OpenSwiftUI/Test/_PerformanceTest.swift
@@ -26,7 +26,7 @@ extension __App {
 
 extension _TestApp {
     public func runPerformanceTests(_ tests: [_PerformanceTest]) -> Never {
-        fatalError("TODO")
+        preconditionFailure("TODO")
     }
 }
 
@@ -37,7 +37,7 @@ extension _BenchmarkHost {
         #elseif os(macOS)
         NSApplication.shared.startedTest(test.name)
         #else
-        fatalError("Unimplemented for other platform")
+        preconditionFailure("Unimplemented for other platform")
         #endif
     }
 
@@ -47,7 +47,7 @@ extension _BenchmarkHost {
         #elseif os(macOS)
         NSApplication.shared.finishedTest(test.name)
         #else
-        fatalError("Unimplemented for other platform")
+        preconditionFailure("Unimplemented for other platform")
         #endif
     }
 
@@ -57,7 +57,7 @@ extension _BenchmarkHost {
         #elseif os(macOS)
         NSApplication.shared.failedTest(test.name, withFailure: nil)
         #else
-        fatalError("Unimplemented for other platform")
+        preconditionFailure("Unimplemented for other platform")
         #endif
     }
 }
diff --git a/Sources/OpenSwiftUI/View/Control/Button/ButtonStyle/TODO/PlainButtonStyle.swift b/Sources/OpenSwiftUI/View/Control/Button/ButtonStyle/TODO/PlainButtonStyle.swift
@@ -12,7 +12,7 @@ public struct PlainButtonStyle: PrimitiveButtonStyle {
     public func makeBody(configuration: Configuration) -> some View {
 //        Button(configuration)
 //            .buttonStyle(buttonStyleRepresentation)
-        fatalError()
+        preconditionFailure("")
     }
 }
 
@@ -35,6 +35,6 @@ private struct PlainButtonStyleBase: ButtonStyle {
 //            configuration.label
 //        }
 //        .opacity(isEnabled ? (configuration.isPressed ? 0.75 : 1.0) : 0.5)
-        fatalError()
+        preconditionFailure("")
     }
 }
diff --git a/Sources/OpenSwiftUI/View/Control/Link/OpenURLActionKey.swift b/Sources/OpenSwiftUI/View/Control/Link/OpenURLActionKey.swift
@@ -26,7 +26,7 @@ struct OpenURLActionKey: EnvironmentKey {
                 completion(error != nil)
             }
             #else
-            fatalError("Unimplemented")
+            preconditionFailure("Unimplemented")
             #endif
         },
         isDefault: true
@@ -51,7 +51,7 @@ struct OpenSensitiveURLActionKey: EnvironmentKey {
             }
             workspace.open(url, configuration: config, completionHandler: completion)
             #else
-            fatalError("Unimplemented")
+            preconditionFailure("Unimplemented")
             #endif
         },
         isDefault: true

diff --git a/Sources/OpenSwiftUI/View/Control/Slider/AnySliderStyle.swift b/Sources/OpenSwiftUI/View/Control/Slider/AnySliderStyle.swift
@@ -13,7 +13,7 @@ protocol SliderStyle {
 
 private class AnyStyleBox {
     func body(configuration _: Slider<SliderStyleLabel, SliderStyleValueLabel>) -> AnyView {
-        fatalError("")
+        preconditionFailure("")
     }
 }
 

diff --git a/Sources/OpenSwiftUI/View/Control/Slider/Slider.swift b/Sources/OpenSwiftUI/View/Control/Slider/Slider.swift
@@ -669,7 +669,7 @@ private struct Normalizing<Value>: Projection where Value: Strideable, Value: Ha
         if let stride {
             let result = (min.distance(to: max) / stride).rounded(.down)
             guard result > 0 else {
-                fatalError("max stride must be positive")
+                preconditionFailure("max stride must be positive")
             }
             length = stride * result
             maxStrides = result
-Original file line number
+Diff line change
@@ Expand Up / @@ -25,7 +25,7 @@ private final class OpenSwiftUIApplication: NSApplication { @@
         }
         required init?(coder: NSCoder) {
-            fatalError("init(coder:) has not been implemented")
+            preconditionFailure("init(coder:) has not been implemented")
         }
     }
     #else
@@ Expand Down @@