Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that Datatable19Version is selected when needed. #34

Merged
merged 1 commit into from
Mar 3, 2016

Conversation

timgws
Copy link
Member

@timgws timgws commented Mar 3, 2016

Write a test for, and fix an issue where Datatable110Version would always be selected, even if Datatable19Version was wanted.

Solves (one of) the issues I was having in #26 where I needed to edit DatatableServiceProvider in order to get data out of a datatable.

@Chumper
Copy link
Contributor

Chumper commented Mar 3, 2016

👍

timgws added a commit that referenced this pull request Mar 3, 2016
Ensure that Datatable19Version is selected when needed.
@timgws timgws merged commit ae66864 into OpenSkill:master Mar 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants