-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Russian translation update, for 2.4.x #933
base: 2.4.x
Are you sure you want to change the base?
Conversation
5d16e5b
to
d3f49d3
Compare
@ValdikSS I saw the update brings some duplicates into cups_ru.po - I found duplicated entries of the following strings:
Can you remove those duplicated entries? Thank you in advance! |
d3f49d3
to
b8ce6de
Compare
Done |
Any comments, updates? |
+1, looks good. |
This PR is pending for more tha 4 months now. Can we somehow proceed with it? I've reviewed this patch, it looks OK for me. And it significantly improves quality of Russian translation. As a lot of time has passed since the PR was created, it has file conflicts now. @ValdikSS, could you please update your changes to resolve these conflicts? Thanks in advance! |
@alexpevzner I'm sorry for that - the changes in one file are too big for Github to show, so I had to copy the ValdikSS file and compare them locally. And once ValdikSS squashed the commits after the last review (which is my problem - I should told him to squash commits once we are done...), I got scared from reviewing the whole file again... I'll try to get to it today. |
@ValdikSS once you get to resolving conflict, please add it as a separate commit - to make distinction about the change (the same in PR for master branch). Thank you in advance! |
@ValdikSS btw is there a reason for replacing tab characters ('\t') and names in upper case letters with names in lower case letters? If there is no reason for them to be like this - other .po files have it in upper case and tabs - would you mind letting them as it is? It would help a lot during review. |
Except for conflict, it looks fine - please look into the conflict (do a separate commit) and I can at least merge 2.4.x and then look into PR for master branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the end, changes like "-P FILENAME.ppd" -> "-P filename.ppd" in msgids are incorrect - those strings have to match with the strings in the actual code.
I see this for "filename", "username", "printer", "job-id", "mime/type", "copies", "title", "name", "value".
EDIT: Looks like the lower case msgids are commented out by #~, so please put the uppercase ones back and comment out the lowercase ones.
These are from OlesyaGerasimenko, I hardly touched .po file myself, only fixed it. |
Where do you see it? Which commit, which line? UPD: sorry I'm dumb, I got it. |
It doesn't seem to be possible to fix merge conflict without rebasing. |
OlesyaGerasimenko's squashed update from #852 + my changes. The same as #895, accidental repo deletion.
For 2.4.x.