Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M #-: Fix detecting RedHat #113

Merged
merged 1 commit into from
Oct 17, 2023
Merged

M #-: Fix detecting RedHat #113

merged 1 commit into from
Oct 17, 2023

Conversation

xorel
Copy link
Member

@xorel xorel commented Oct 17, 2023

No description provided.

@rsmontero rsmontero merged commit 95451ea into master Oct 17, 2023
1 of 3 checks passed
@rsmontero rsmontero deleted the fix-redhat branch October 17, 2023 11:59
@mkutouski
Copy link
Contributor

Should that script be capable to install miniONE on RHEL OS apart from detecting RHEL ? Because with that fix the script failed on RHEL 9.2.:

$ cat /etc/redhat-release 
Red Hat Enterprise Linux release 9.2 (Plow)


$ git clone https://github.com/OpenNebula/minione.git

$ bash /root/minione/minione
Checks & detection
Checking distribution and version [RedHat 9 6.6]  FAILED

As far as I understand the RedHat8 and RedHat9 need to be listed in SUPPORT_MAP. But even after that the script fails on checking OpenNebula URL with the error message as below:

$ bash /root/minione/minione -v

### Checks & detection
Checking distribution and version [RedHat 9 6.6]  OK
Checking if OpenNebula repository exists  retry 1 retry 2 retry 3 FAILED

--- STDERR ---
Currently only CentOS, AlmaLinux, Ubuntu or Debian are supported
--------------

Since RedHat and AlmaLinux are binary compatible may be one of the possible solution can be just set

[[ "${DIST}" = Red ]] && DIST="AlmaLinux"

with some workaround for EPEL repository?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants