Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translation cleanup #149

Draft
wants to merge 2 commits into
base: publish
Choose a base branch
from
Draft

translation cleanup #149

wants to merge 2 commits into from

Conversation

danbjoseph
Copy link
Collaborator

storing all the translation files in the repo doesn't seem to be adding much value, and ends up with LOTS of changed files every time there's a change and we want to update all the languages. this PR takes those files out of the repo, and pulls the language strings down from Transifex during the build process. currently, in order to push changes that have occurred up to Transifex for translation, we still need to run:

make updatepot
make updatelangpo
make pushlang

but that could be changed to occur during the build process as well.

@pierotofy
Copy link
Member

Thanks @danbjoseph 👍 I think this might have some issues with the build command make pulllang, for example on a brand new environment I get:

make pulllang
tx pull --language "sw,ar,es,fr,te,fil,id"

Did you know that you can create an apitoken under your transifex user's settings?
(Read more at https://docs.transifex.com/api/introduction#authentication)
So, do you have an api token? [y/N]:

So the automated build would hang here.

@danbjoseph
Copy link
Collaborator Author

ah, you're right, i completely forgot about that piece. i'll look into if it's possible to get around that securely.

@smathermather smathermather marked this pull request as draft August 1, 2024 14:05
@smathermather
Copy link
Contributor

@danbjoseph -- any solution for doing this securely?

@danbjoseph
Copy link
Collaborator Author

should be possible with https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions
i can try and take a look soon

@smathermather
Copy link
Contributor

Makes sense. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants