Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CoreDHCP to Helm #87

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add CoreDHCP to Helm #87

wants to merge 1 commit into from

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Nov 8, 2024

Remove dnsmasq from the Helm chart. Add Deployments for atftpd and CoreDHCP.

Related to #86

@rainest rainest mentioned this pull request Nov 8, 2024
3 tasks
@alexlovelltroy
Copy link
Member

@rainest This is still marked as WIP. Do you anticipate trying to close it this month?

@rainest rainest force-pushed the rainest/dhcp-refactor branch 2 times, most recently from 3cf417a to 9467887 Compare December 18, 2024 01:11
@rainest
Copy link
Contributor Author

rainest commented Dec 18, 2024

@alexlovelltroy end of month may be iffy, as nothing will happen after the 23rd. Depends on how much we're okay with a less than ideal implementation.

The current set of commits brings it in line with the updated coredhcp with built-in TFTP, though that appears a bit broken still--my attempts to get files that should be available resulted in timeouts, so I need to figure out what's up with the routing there.

The initContainer population of the the TFTP artifacts is probably functional, but poor design and quite slow. IDK that there's any particularly good option there without image volumes, which won't really be an option for a while. PV initialization would deal with restart slowness, but IIRC Helm hook behavior makes that very annoying to deal with.

IMO that storage is probably better handled out of band, but that doesn't really work for an all-in-one quickstart.

Nevermind, moot point as of c379d16. These are now baked in.

Aside from the missing hosts file, I can probably live with the ugly templated YAML doc within a ConfigMap for now.

Switch from dnsmasq to coredhcp with coresmd for DHCP and TFTP/iPXE services.
@rainest rainest force-pushed the rainest/dhcp-refactor branch from 9467887 to 332d053 Compare December 18, 2024 22:54
@rainest
Copy link
Contributor Author

rainest commented Dec 18, 2024

332d053 is ready-ish with the lazy templated YAML string within a ConfigMap nonsense. It can't actually serve TFTP outside the cluster without OpenCHAMI/coresmd#14, but won't really change after that--just a coresmd version bump and the additional plugin toggle.

TFTP pulls from within the cluster do work fine, so aside from the CNI fun, it's working as expected.

#86 (comment) explains this. dnsmasq may have a single-port mode similar to coresmd#14 below, but I don't see that we had it configured, so I don't think this was likely working before.

Haven't tried DHCP; need to find a simple way to test that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants