Improve trivy checks #1790
Merged
Improve trivy checks #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmthomas
commented
Dec 20, 2024
| @@ -79,7 +79,8 @@ RUN apk update \ | |||
| && python3 -m venv /openc3/venv \ | |||
| && source /openc3/venv/bin/activate \ | |||
| && pip3 config --global set global.index $PYPI_URL/pypi \ | |||
| && pip3 config --global set global.index-url $PYPI_URL/simple | |||
| && pip3 config --global set global.index-url $PYPI_URL/simple \ | |||
| && pip3 install --upgrade pip setuptools | |||
There was a problem hiding this comment.
This addresses a few CVEs in the setuptools
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1790 +/- ##
=======================================
Coverage 79.57% 79.57%
=======================================
Files 517 517
Lines 40737 40737
=======================================
Hits 32418 32418
Misses 8319 8319
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
ryan-pratt
approved these changes
Dec 20, 2024
|
The remaining CVEs detected by trivy will have to wait for upstream fixes to minio / mc and traefik |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.