Small bug fixes and enhancements #1772
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1772 +/- ##
==========================================
- Coverage 79.58% 79.56% -0.02%
==========================================
Files 517 517
Lines 40736 40737 +1
==========================================
- Hits 32419 32412 -7
- Misses 8317 8325 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -308,10 +308,13 @@ export default { | |||
| }, | |||
| computedStyle() { | |||
| let style = {} | |||
| // note down what the width was in case it was set to AUTO, because absolute positioning will lose that | |||
| const origWidth = this.width || this.$refs.bar?.clientWidth | |||
There was a problem hiding this comment.
I was surprised that setting a width and height doesn't actually change the width / height. We set the vcard min-height and min-width so the only option is to set a screen bigger than the actual layout. I was expecting a scrollable window with a set width and height. Thoughts? This could be another ticket later.
| this.saveDefaultConfig(this.currentConfig) | ||
| } else { | ||
| this.items = [] | ||
| } |
There was a problem hiding this comment.
I'm not sure why you're doing this if check. Don't we always want to clear the items and then save the config?
There was a problem hiding this comment.
Clearing the items does save the config because of the items watcher. This check makes sure that we only save the config once instead of spamming that function
|
closes #1765
closes #1768
closes #1766