Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19998.
Note that even if the synchronous test API client does not raise any warning when it's not closed, I still updated the template for it so that the behaviour aligns with the async version.
As of the samples, in this PR I updated the asyncio samples only. I did try to update the regular python samples as well, but it seems that most samples are severely outdated, especially for tests because the generator does not overwrite test files if they already exist, though I don't know why there is this rule in the generator, and therefore I would have to update a lot of irrelevant lines along with the core changes in this PR, which does not seem to be a good idea. I'm happy to update the samples in a separate PR.
Test
Generated some code locally:
without the warning mentioned in #19998.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@tomplus Please help review this PR. Thank you!