Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move examples dir from the libmetal repository #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move examples dir from the libmetal repository #21

wants to merge 1 commit into from

Conversation

kernelchuk
Copy link

Move examples directory from https://github.com/OpenAMP/libmetal into examples/libmetal.

@kernelchuk
Move examples dir from the libmetal repository
edd999d 
Move examples directory from https://github.com/OpenAMP/libmetal
into examples/libmetal. Moved files (LANG=C tree examples/libmetal):
examples/libmetal
|-- CMakeLists.txt
`-- system
    |-- CMakeLists.txt
    |-- freertos
    |   |-- CMakeLists.txt
    |   `-- zynqmp_r5
    |       |-- CMakeLists.txt
    |       `-- zynqmp_amp_demo
    |           |-- CMakeLists.txt
    |           |-- common.h
    |           |-- ipi_latency_demod.c
    |           |-- ipi_shmem_demod.c
    |           |-- libmetal_amp_demod.c
    |           |-- lscript.ld
    |           |-- platform_config.h
    |           |-- shmem_atomic_demod.c
    |           |-- shmem_demod.c
    |           |-- shmem_latency_demod.c
    |           |-- shmem_throughput_demod.c
    |           |-- sys_init.c
    |           `-- sys_init.h
    |-- generic
    |   |-- CMakeLists.txt
    |   `-- zynqmp_r5
    |       |-- CMakeLists.txt
    |       `-- zynqmp_amp_demo
    |           |-- CMakeLists.txt
    |           |-- common.h
    |           |-- ipi_latency_demod.c
    |           |-- ipi_shmem_demod.c
    |           |-- libmetal_amp_demod.c
    |           |-- lscript.ld
    |           |-- platform_config.h
    |           |-- shmem_atomic_demod.c
    |           |-- shmem_demod.c
    |           |-- shmem_latency_demod.c
    |           |-- shmem_throughput_demod.c
    |           |-- sys_init.c
    |           `-- sys_init.h
    `-- linux
        |-- CMakeLists.txt
        `-- zynqmp
            |-- CMakeLists.txt
            `-- zynqmp_amp_demo
                |-- CMakeLists.txt
                |-- common.h
                |-- ipi_latency_demo.c
                |-- ipi_shmem_demo.c
                |-- libmetal_amp_demo.c
                |-- libmetal_amp_demod.c
                |-- shmem_atomic_demo.c
                |-- shmem_demo.c
                |-- shmem_latency_demo.c
                |-- shmem_throughput_demo.c
                |-- sys_init.c
                `-- sys_init.h

10 directories, 46 files

Signed-off-by: Sergei Korneichuk <[email protected]>
@kernelchuk kernelchuk mentioned this pull request Sep 16, 2023
Closed
@arnopo
Copy link
Collaborator

arnopo commented Sep 19, 2023

@kernelchuk ,
I'm trying to funderstand what is mandatory and not for AMD project.

Could you clarify the need of this examples for AMD?

By essence the libmetal is used to adapt the openamp lib to the target ( compiler, platform, OS). Do you have some project using only lib metal?

So i wonder if this code is only for legacy and what you really need is just open-amp examples running on AMD platforms (#19)

@kernelchuk
Copy link
Author

@arnopo,
The libmetal example - zynqmp_amp_demo is used in our Vitis tool as described in https://docs.xilinx.com/r/en-US/ug1186-zynq-openamp-gsg/Xilinx-Libmetal-AMP-Demo

Other projects at AMD use libmetal without OpenAMP. From the top of my head: RFDC. We also use it internally for testing and validation. This is not legacy code.

@kernelchuk kernelchuk mentioned this pull request Nov 7, 2023
Closed
@wmamills
Copy link
Collaborator

@tnmysh I presume your PR# 44 makes this redundant correct?
If so please close this one.

@tnmysh
Copy link
Collaborator

tnmysh commented Jul 1, 2024

@wmamills as part of PR#44, I am moving only open-amp repository demos. I would like to keep this open, till we move libmetal demos as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmooring edmooring Awaiting requested review from edmooring

@arnopo arnopo Awaiting requested review from arnopo

@wmamills wmamills Awaiting requested review from wmamills

@tnmysh tnmysh Awaiting requested review from tnmysh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kernelchuk @arnopo @wmamills @tnmysh