virtqueue cleanup #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unused structure elements and greatly reduce the size of virtqueue at runtime. Also re-ordered boolean vq_inuse to reduce internal padding of the struct. Signed-off-by: Kumar Gala <[email protected]>
We only use vq_alignment during init once. We don't need to save the value in the struct, so remove it to reduce the size of the struct. Signed-off-by: Kumar Gala <[email protected]>
wjliang
reviewed
Apr 12, 2018
lib/virtio/virtqueue.c
Outdated
| @@ -81,10 +81,9 @@ int virtqueue_create(struct virtio_device *virt_dev, unsigned short id, | |||
| vq->shm_io = shm_io; | |||
|
|
|||
| //TODO : Whether we want to support indirect addition or not. | |||
There was a problem hiding this comment.
can also remove this comments
wjliang
reviewed
Apr 12, 2018
lib/virtio/virtqueue.c
Outdated
| if (vq->vq_ring_mem != NULL) { | ||
| vq->vq_ring_mem = NULL; | ||
| } | ||
| //TODO : Need to free indirect buffers here |
There was a problem hiding this comment.
we can also remove this comments
As we don't have indirect support, lets remove vq_ring_size for now since we don't really need vq_ring_size for anything else. Signed-off-by: Kumar Gala <[email protected]>
As we don't have indirect support, lets remove vq_ring_mem for now since we don't really need vq_ring_mem for anything else. Signed-off-by: Kumar Gala <[email protected]>
We can open issues to track any todo items. Signed-off-by: Kumar Gala <[email protected]>
|
Removed TODO comments in virtqueue completely, any such items we can track with git hub issues going forward. I opened Issue #54 for indirect descriptor support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanups to the virtqueue implementation to remove some dead code and reduce the struct virtqueue size to drastically reduce the memory requirements for dynamic allocation.