Docs: fix for the readthedocs PR rendering #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original procedure worked only when the PR was coming from the same repo that was the target of the PR. This is not normally the case. The original check out has the commit we need. Just use it as the remote, fetch and checkout the commit hash we need. Signed-off-by: Bill Mills <[email protected]>
|
OK I have done as much testing as I can. I used two different forks of libmetal and sent a PR from one to the other. What I found was we need the new .readthedocs.yaml (the one from this fix) So what this means is THIS PR will pass (and it did above). Sorry the history is messy but hopefully it is OK now. |
|
Once this is accepted I will rebase my fix the wiki PR and resubmit it and we can see this in action for real. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original procedure worked only when the PR was coming from the same repo that was the target of the PR. This is not normally the case.
The original check out has the commit we need. Just use it as the remote, fetch and checkout the commit hash we need.