Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete registration rewrite and add new registration modes #61

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

Ooglely
Copy link
Owner

@Ooglely Ooglely commented Sep 19, 2024

Rewriting the entire registration and update system in order to reduce the number of loop crashes in the future, and to add new registration modes such as allowing roles for both modes or the highest of the two modes.

Features

  • Add BotMenu class to replace old classes for each different menu
  • Add Combined and Both to /registration setup
  • Support new reg role storage in the database
  • Support Both and Combined modes in update_roles loop
  • Improve error handling throughout update_roles
  • Add new command for removing all bypass roles
  • Replace all other menus that relied on old registration menu classes
  • Improve /updateall
  • Add command to run update for all db players (owner only)
  • Add command to unregister player (owner only)
  • Rewrite webserver to use new RegistrationSettings class

Tests

  • /registration with all modes
  • All menus that have to be replaced as part of menu rewrite
  • /updateall with each mode in pugBot server
  • Test /registration with old registration setups in db
  • Test registration through website

@Ooglely Ooglely added the enhancement New feature or request label Sep 19, 2024
@Ooglely Ooglely self-assigned this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant