Subcommands and Extensions #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
approved these changes
May 4, 2024
| Binary { | ||
| name: "cargo-stylus-test", | ||
| apis: &["test", "t"], | ||
| rust_flags: Some(r#"RUSTFLAGS="-C link-args=-rdynamic""#), |
There was a problem hiding this comment.
Nice that we can specify the rust flags here right away to not push this to the caller
|
All commands tested, fixed up some hostio issues, but still need a few more edits to hostios in a follow-up PR. Very excited to finally get this in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
cargo stylusinto a series of sub commands which are invoked in child processes. This allows for a cleaner architecture as we add new features, and allows 3rd party extensions to our tool.