verify and reproducible subcommands #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikebenfield
force-pushed
the
contract-verification
branch
2 times, most recently
from
98b202d to
193bde5
Compare
rauljordan
approved these changes
Feb 5, 2024
src/verify.rs
Outdated
| input: String, | ||
| } | ||
|
|
||
| fn hex_str_to_bytes(s: &str) -> eyre::Result<Vec<u8>> { |
There was a problem hiding this comment.
The hex crate does this, I believe, and we already depend on it hex::decode
src/verify.rs
Outdated
|
|
||
| pub async fn verify(cfg: VerifyConfig) -> eyre::Result<()> { | ||
| let provider = util::new_provider(&cfg.common_cfg.endpoint)?; | ||
| let result: RpcResult = provider |
There was a problem hiding this comment.
We can also use the direct, get_transaction method https://docs.rs/ethers/latest/ethers/providers/struct.Provider.html#method.get_transaction
mikebenfield
force-pushed
the
contract-verification
branch
from
193bde5 to
cc11ed6
Compare
|
This PR is essentially done, but we're waiting until a cargo stylus refactor to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes STY-77