Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code duplication that led to inconsistencies #116

Merged
merged 6 commits into from
Nov 21, 2024

Conversation

gligneul
Copy link
Contributor

@gligneul gligneul commented Nov 8, 2024

  • Add an option to the deploy command to disable the activation.
  • Unify the activation fee bump in the deploy and activate commands.
  • Unify the git init behavior in the new and init commands.

Close STY-159

This is useful when we want to run the cargo stylus activate command
separately.
Now the deploy and activate commands have the same option to set the
activation fee bump value.
* The new command creates the project directory and calls the init
  command.
* The init code removes the git origin from the project directory.
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gligneul gligneul merged commit 1b8f476 into develop Nov 21, 2024
7 checks passed
@gligneul gligneul deleted the gligneul/audit-m-07 branch November 21, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants