Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality for saving to .evl and .evr files #199

Merged
merged 9 commits into from
Apr 26, 2024

Conversation

ctuguinay
Copy link
Collaborator

@ctuguinay ctuguinay commented Apr 25, 2024

Added functions for saving to .evl and .evr. Addresses #192 and #186

@ctuguinay ctuguinay marked this pull request as draft April 25, 2024 20:40
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.89%. Comparing base (a6d1ded) to head (de1a895).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
- Coverage   91.20%   90.89%   -0.32%     
==========================================
  Files          13       13              
  Lines         830      637     -193     
==========================================
- Hits          757      579     -178     
+ Misses         73       58      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ect evr, fix docstrings and types, fix naming in tests
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ctuguinay ctuguinay marked this pull request as ready for review April 26, 2024 17:49
@ctuguinay ctuguinay merged commit 670bbf8 into main Apr 26, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Regions2d DataFrame -> EVR functionality Consider renaming Regions2D.mask and Regions2D.transect_mask?
1 participant