Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update software behavior to use the default echopype home directory #954

Merged
merged 14 commits into from
Mar 11, 2023

Conversation

lsetiawan
Copy link
Member

@lsetiawan lsetiawan commented Mar 6, 2023

Overview

This PR updates software behavior to start utilizing the default echopype home directory located in user's home directory: ~/.echopype.

Related Issues

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2023

Codecov Report

Merging #954 (c560b46) into dev (33f2f1a) will decrease coverage by 18.45%.
The diff coverage is 80.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##              dev     #954       +/-   ##
===========================================
- Coverage   79.48%   61.04%   -18.45%     
===========================================
  Files          62       62               
  Lines        5650     5647        -3     
===========================================
- Hits         4491     3447     -1044     
- Misses       1159     2200     +1041     
Flag Coverage Δ
unittests 61.04% <80.00%> (-18.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
echopype/convert/api.py 88.80% <ø> (ø)
echopype/core.py 86.20% <ø> (-2.03%) ⬇️
echopype/utils/io.py 77.84% <66.66%> (-12.46%) ⬇️
echopype/__init__.py 100.00% <100.00%> (ø)
echopype/convert/parsed_to_zarr.py 85.34% <100.00%> (ø)
echopype/echodata/combine.py 69.92% <100.00%> (ø)

... and 24 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lsetiawan lsetiawan added the enhancement This makes echopype better label Mar 7, 2023
@lsetiawan lsetiawan added this to the 0.6.4 milestone Mar 7, 2023
@lsetiawan lsetiawan self-assigned this Mar 7, 2023
@lsetiawan lsetiawan closed this Mar 7, 2023
@lsetiawan lsetiawan reopened this Mar 7, 2023
@lsetiawan lsetiawan marked this pull request as ready for review March 7, 2023 23:50
echopype/convert/api.py Outdated Show resolved Hide resolved
docs/source/convert.rst Outdated Show resolved Hide resolved
Copy link
Member

@leewujung leewujung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lsetiawan : I made some small edits because ~/.echopype is not in the working directory, but other than that I think this is ready to be merged.

Could you insert a section in the documentation for the examples of where files will be saved in different scenarios? I think that will be really helpful for the users. Thanks!

@leewujung leewujung mentioned this pull request Mar 11, 2023
17 tasks
@leewujung leewujung merged commit e9d45f5 into OSOceanAcoustics:dev Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This makes echopype better
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants