-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed reorganization of AD2CP data format #719
base: dev
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…nto ad2cp-reorg
A new question as I test the new parser/organization from #731 using data from my fieldwork last year: This is an example of the config string saved as a txt file: @imranmaj has a nice function in the parser to convert the config string to dict, and it is used in the parser for getting some specific info, but the config params are not saved in general. @emiliom : Do you have recommendation on how this should be saved? I see this as similar to the config XML that is saved in its entity for EK80 in the echopype/echopype/convert/set_groups_ek80.py Line 988 in 12693a7
|
Given that "BEAMCFGLIST": [dict1, dict2, ...] |
In v0.6.0 we left out AD2CP data because it takes quite a different flavor from all the other sonar models. Now we are in the position to reorganize the data format based on the previous experience.
In this PR I put in a markdown file that details my proposed changes of the data format. The file is put under
docs/source
but my intension is not to merge this file but use this PR as a place where we can do line by line exchanges/discussions if needed.@emiliom @imranmaj : I think it may work better if @emiliom and I meet first to settle down the proposed changes (which will be become new commits to this PR), and then @imranmaj and I meet to go through the required changes.
@emiliom: I can give you an overview of how this instrument operations and the main differences from the other sonar models. The variables are in such a way that can be grouped into a few conceptual groups, so even though there are a large number of them I think it won't be too hard for us to make decisions.
@imranmaj: There are a few questions that are independent of the format changes. We can discuss those in parallel.