-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added sonar model checkers for EK60, EK80, ER60, AZFP6, AZFP, AD2CP and tests #1399
Open
spacetimeengineer
wants to merge
31
commits into
OSOceanAcoustics:main
Choose a base branch
from
spacetimeengineer:Parse-sonar-model-from-.raw-for-EK60,-EK80
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
94ec110
Added sonar model checkers for EK60, EK80
spacetimeengineer cae865e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 2cb2625
Update parse_ek60.py
spacetimeengineer 7bf89a1
Added test cases for EK60 and EK80 model validation
spacetimeengineer 1affd2d
Fixed the tests.
spacetimeengineer 2abe8be
Fixed an import error
spacetimeengineer fa7dc1c
Test fix + Update to documentation for Docker and sudo privileges
spacetimeengineer adb5111
Update parse_ek60.py
spacetimeengineer 8967c3e
Refactor error handling: Removed unnecessary 'e' variable
spacetimeengineer 53367cd
chore(deps): bump actions/cache from 4.1.1 to 4.1.2 (#1400)
dependabot[bot] ca2adf9
chore(deps): bump actions/setup-python from 5.2.0 to 5.3.0 (#1401)
dependabot[bot] 907424d
Made tests better so that they run through all test files in the test…
spacetimeengineer 8a2517d
Added better tests for ek80 checker functions.
spacetimeengineer 01ceb52
Added the rest of the sonar checkers.
spacetimeengineer 0534589
Update test_convert_azfp6.py
spacetimeengineer 853d01b
Added more tests
spacetimeengineer d3467f5
Update test_convert_azfp.py
spacetimeengineer bf73faa
Corrected some tests.
spacetimeengineer a8cd12b
Merge branch 'Parse-sonar-model-from-.raw-for-EK60,-EK80' into parse-…
spacetimeengineer 4db7dd5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 9929523
Needed some fixes for the merge.
spacetimeengineer 1f8f44d
Merge branch 'Parse-sonar-model-from-.raw-for-EK60,-EK80' of https://…
spacetimeengineer d128ff7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 48d9d6b
More merge fixes.
spacetimeengineer 80b6656
Update __init__.py
spacetimeengineer 29ce582
Finishing 1399 requests from Dr. Wu-Jung
spacetimeengineer 20d0932
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] dea1f3c
Adding more PR requests.
spacetimeengineer 35f6e0f
Adding in more requests.
spacetimeengineer afd3bd2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 4574f81
More fixes for PR1399
spacetimeengineer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure why you are accessing the timestamp here.
See Gavin's #494 (comment) that I think would be useful here to check the format without using the full blown parser. Implementing that into the checker would address #494 too in this PR.