Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In tabular reports, should subtotals be implemented where present in Matlab EchoPro? #92

Closed
emiliom opened this issue Feb 15, 2023 · 4 comments

Comments

@emiliom
Copy link
Contributor

emiliom commented Feb 15, 2023

For the len-age binned data reports that currently (Matlab EchoPro) include subtotal rows and columns plus other annotation rows, we did not implement such subtotals in the initial implementation of the generate-reports capability (PR #84). We discussed this feature in a meeting with the FEAT team in Jan. 2023 about the report files, but didn't come to a definitive conclusion.

For now, the Excel report files that are generated are simple tables with a single header row and no sub-totals or additional annotations. Some of those files contain 3 tabs (3 tables), though, for male/female/all sexes.

We'll revisit this in a future meeting.

Update [@leewujung 2023/12/08]: see #112 for:

  • Links to the report files from 2019 data
  • Meeting discussions for requirement for Python EchoPro
  • Side-by-side comparison table between Matlab and Python EchoPro
@emiliom
Copy link
Contributor Author

emiliom commented Dec 8, 2023

We haven't heard back as to whether adding these subtotals will be a requirement.

@leewujung
Copy link
Member

leewujung commented Dec 8, 2023

For the len-age binned data reports that currently (Matlab EchoPro) include subtotal rows and columns plus other annotation rows

@emiliom : Could you provide links to the report files from Matlab EchoPro and Python EchoPro, and the list the differences if you have them? I tried to look into the google folder but it is not clear to me which are the ones to reference. Thanks.

Edit: Turns out those are summarized in #112. I will add this to the top comment of this issue.

@rebeccathomas-NOAA
Copy link
Collaborator

The subtotals are used by stock assessment in their data links, so it would be an important aspect of the data summary reports to replicate.

@brandynlucca
Copy link
Collaborator

This has been encapsulated within #290 and can therefore be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants