Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify a collection of desired output plots #145

Closed
leewujung opened this issue Dec 6, 2023 · 3 comments
Closed

Identify a collection of desired output plots #145

leewujung opened this issue Dec 6, 2023 · 3 comments

Comments

@leewujung
Copy link
Member

leewujung commented Dec 6, 2023

This google doc includes a collection of plots generated by Matlab EchoPro. Some plots have wrong axis labels, but those are easy to correct.

This issue to track discussions for what outputs we want for the python version.

@leewujung leewujung changed the title Identify a collection of output plots Identify a collection of desired output plots Dec 6, 2023
@leewujung leewujung added the FEAT label Dec 6, 2023
@rebeccathomas-NOAA
Copy link
Collaborator

Do you have any thoughts for how best to "id" plots? I know I have some plots in mind to absolutely have, but I'm not really sure how to refer to them.

@leewujung
Copy link
Member Author

leewujung commented Feb 2, 2024

Here's the link to the recording (restricted access) for the meeting where @rebeccathomas-NOAA walks through and discusses the figures she uses in Matlab EchoPro: https://drive.google.com/file/d/1Cm-fJadhdND0d-_tK0j-roFr-Vxk3ysr/view?usp=drive_link

The key highlights are:

  • There are a few plots that got generated in the beginning that is related to Echoview NASC exports that we need to produce, since it is useful for debugging the input files
  • The interactive capability with kriging outputs on the map has been implemented, just need:
    • updating for new data structure
    • making sure things run in clean environment
  • The combination of plots that basically extract and plot data from the "result dataframes" (either based on transect results or kriging outputs) can be easily produced once the codebase overhaul is completed. We will:
    • make a documentation showing what is in which result dataframes
    • the documentation will also include how to produce useful plots
    • the docs will use Jupyter notebooks, so that the cells are directly executable and reproducible, so it would be easy to modify for working with data from another year
    • add jupyter notebooks that shows how to plot

@rebeccathomas-NOAA @brandynlucca : the above are what I remembered from our 2024/01/29 meeting. Feel free to make any corrections or additions!

@brandynlucca
Copy link
Collaborator

This has been encapsulated within #290 and can therefore be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants