Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Draft For Revamped Echoflow Design #22

Merged
merged 31 commits into from
Oct 11, 2023
Merged

Initial Draft For Revamped Echoflow Design #22

merged 31 commits into from
Oct 11, 2023

Conversation

Sohambutala
Copy link
Collaborator

  • Revamped configuration files
  • Separated flows and tasks based on API defined in Echopype
  • Organized utility functions based on their corresponding functionalities.

@Sohambutala Sohambutala marked this pull request as ready for review July 14, 2023 19:46
@Sohambutala Sohambutala marked this pull request as draft July 14, 2023 19:47
@valentina-s
Copy link
Collaborator

valentina-s commented Sep 2, 2023

Thanks for adding the notebooks with nice explanations @Sohambutala! I tried the LocalEchoflowDemo.ipynb and here are a few notes on the experience:

  • first I needed to create some profile to initiate .profile folder. I ran prefect profile create test
  • I also was missing the echoflow init step and got the error about the missing .echoflow/echoflow_rules.txt. I ran it through python echoflow/echoflow_cli.py init and it worked, so I assume you had some alias set up. Could add a reminder in the notebook that people should have gone through these steps.
  • I got some connection time out errors. In the end I limited to 10 files and the command completed. My laptop had at least 24GB of free RAM at that moment.
Screenshot 2023-08-31 at 4 48 46 PM * I retried today with 100 files, and it is working, i.e. I obtained the individual objects but I still had some connection refused error: Screenshot 2023-09-01 at 6 28 14 PM

Anyway, it could be RAM dependence.

  • You can also some explanation of what the data object was: It is a list of one entry with 10 elements (the xarray datasets) corresponding to the files.

@Sohambutala
Copy link
Collaborator Author

Thank you @valentina-s! Based on your feedback/comments here is the revision:

  1. Added setup and initialization instructions in the offline notebook.
  2. Resolved the "connection refused" issue stemming from the outdated method used to fetch previous flows from the Prefect REST API.
  3. Introduced a shell script that can be executed on any machine to initiate echoflow as a systemd process.

@leewujung leewujung requested a review from valentina-s October 9, 2023 22:55
@Sohambutala Sohambutala marked this pull request as ready for review October 9, 2023 22:56
Copy link
Collaborator

@valentina-s valentina-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Thank you so much!

@Sohambutala Sohambutala merged commit 4022bac into main Oct 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants