fix(snippet.js): corner cases of Snippet Lines (#85)

OI-wiki · Dec 2, 2024 · 4527343 · 4527343
1 parent d6b8fe9
commit 4527343
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/oi-wiki-export-typst/snippet.js b/oi-wiki-export-typst/snippet.js
@@ -11,12 +11,12 @@ function resolvePath(snip, spacesAtStart) {
   if ((str.startsWith('"') && str.endsWith('"')) ||
     (str.startsWith("'") && str.endsWith("'"))) {
     const strs = str.substring(1, str.length - 1).split(":")
-    res.path = strs[0]
-    if (strs.length == 3) {
-      res.beg_line = Number(strs[1]) - 1
-      res.end_line = Number(strs[2])
-    } else if (strs.length != 1) {
+    if (strs.length < 1 || strs.length > 3) {
       console.error('cannot parse snippet:', snip)
+    } else {
+      res.path = strs[0]
+      res.beg_line = strs[1] ? Number(strs[1]) - 1 : undefined
+      res.end_line = strs[2] ? Number(strs[2]) : undefined
     }
   } else {
     console.error('cannot parse snippet:', snip)

diff --git a/oi-wiki-export/snippet.js b/oi-wiki-export/snippet.js
@@ -13,12 +13,12 @@ function resolvePath(snip, spacesAtStart) {
     (str.startsWith("'") && str.endsWith("'"))
   ) {
     const strs = str.substring(1, str.length - 1).split(":");
-    res.path = strs[0];
-    if (strs.length == 3) {
-      res.beg_line = Number(strs[1]) - 1;
-      res.end_line = Number(strs[2]);
-    } else if (strs.length != 1) {
+    if (strs.length < 1 || strs.length > 3) {
       console.error("cannot parse snippet:", snip);
+    } else {
+      res.path = strs[0];
+      res.beg_line = strs[1] ? Number(strs[1]) - 1 : undefined;
+      res.end_line = strs[2] ? Number(strs[2]) : undefined;
     }
   } else {
     console.error("cannot parse snippet:", snip);