-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/buffer undefined (Issue 3588) #3590
Conversation
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## master #3590 +/- ##
=======================================
Coverage 42.58% 42.58%
=======================================
Files 80 80
Lines 1463 1463
Branches 340 340
=======================================
Hits 623 623
Misses 675 675
Partials 165 165 Continue to review full report in Codecov by Sentry.
|
Context
For Issue 3588: Changes in webpack config may have caused Buffer to be undefined when using datasetToBlob function from dcmjs dependency.
Applying buffer definition under plugins appears to be a solution:
https://stackoverflow.com/questions/68707553/uncaught-referenceerror-buffer-is-not-defined
webpack/changelog-v5#10
Changes & Results
Added buffer definition under webpack config.plugins allows datasetToBlob to work again.
Testing
RT report should be prepared and prompt to save show up.
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment