Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/buffer undefined (Issue 3588) #3590

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Conversation

dxlin
Copy link
Contributor

@dxlin dxlin commented Aug 9, 2023

Context

For Issue 3588: Changes in webpack config may have caused Buffer to be undefined when using datasetToBlob function from dcmjs dependency.

Applying buffer definition under plugins appears to be a solution:
https://stackoverflow.com/questions/68707553/uncaught-referenceerror-buffer-is-not-defined

webpack/changelog-v5#10

Changes & Results

Added buffer definition under webpack config.plugins allows datasetToBlob to work again.

Testing

  1. Start viewer
  2. Select Water Phantom study (or any with CT and PT) in TMTV mode
  3. Create "New Label" on right right
  4. Select "Rectangle ROI Threshold Tool"
  5. Create arbitrary rectangle in axial PT viewport
  6. Click "Run"
  7. Click "Create RT Report"

RT report should be prepared and prompt to save show up.

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS: Windows 10
  • [] Node version: 18.16.0
  • [] Browser: Edge v115.0.1901.188

@netlify
Copy link

netlify bot commented Aug 9, 2023

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 5d93fa0
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/64d3df1b737e1b0008f0810e
😎 Deploy Preview https://deploy-preview-3590--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 9, 2023

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 5d93fa0
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/64d3df1b346f3400084d5869
😎 Deploy Preview https://deploy-preview-3590--ohif-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #3590 (5d93fa0) into master (b55518e) will not change coverage.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3590   +/-   ##
=======================================
  Coverage   42.58%   42.58%           
=======================================
  Files          80       80           
  Lines        1463     1463           
  Branches      340      340           
=======================================
  Hits          623      623           
  Misses        675      675           
  Partials      165      165           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aedb9d1...5d93fa0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants