Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][FIX] base_technical_features: fix incorrect replacement #980

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

trisdoan
Copy link

@trisdoan trisdoan commented Dec 5, 2024

Context

  • Sometimes group is negated like this: groups="!base.group_no_one"
  • Without this fix, result of arch is groups="!base.group_no_one,base_technical_features.group_technical_features", which is wrong

Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

@simahawk
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-980-by-simahawk-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 570079c into OCA:18.0 Dec 19, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 085f11d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants