Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][IMP] base_tier_validation: add icon #979

Merged
merged 1 commit into from
Dec 4, 2024
Merged

[17.0][IMP] base_tier_validation: add icon #979

merged 1 commit into from
Dec 4, 2024

Conversation

AlexPForgeFlow
Copy link

@AlexPForgeFlow AlexPForgeFlow commented Dec 2, 2024 •
edited
Loading

Proposal of icon for Tier Validation

@OCA-git-bot
Copy link
Contributor

Hi @LoisRForgeFlow,
some modules you are maintaining are being modified, check this out!

@AlexPForgeFlow AlexPForgeFlow changed the title [IMP] base_tier_validation: add icon [17.0][IMP] base_tier_validation: add icon Dec 2, 2024
LoisRForgeFlow
LoisRForgeFlow reviewed Dec 2, 2024
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you reduce the blank space around the icon? Odoo automatically add border in the menu icons:

image

Also can you make sure that the image size is squared. Ideally 128x128 pixels (OCA icons) or 100x100 (Odoo 17 icons)

pedrobaeza
pedrobaeza reviewed Dec 2, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement! The usual size is 140x140 though, and it would be great if you provide the source SVG for derivatives.

@AlexPForgeFlow AlexPForgeFlow force-pushed the 17.0-add-icon-base_tier_validation branch 2 times, most recently from 87bd866 to 605bd9a Compare December 2, 2024 16:10
LoisRForgeFlow
LoisRForgeFlow approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pedrobaeza pedrobaeza added this to the 17.0 milestone Dec 3, 2024
@pedrobaeza
Copy link
Member

What about the SVG source?

@AlexPForgeFlow
Copy link
Author

@pedrobaeza I don’t have the SVG source, I did it other way

@pedrobaeza
Copy link
Member

OK, I have re-done it on SVG from your idea. Can you please include them? (the PNG has been re-exported from the SVG)

icon
icon

@AlexPForgeFlow AlexPForgeFlow force-pushed the 17.0-add-icon-base_tier_validation branch from 605bd9a to c297772 Compare December 4, 2024 08:44
pedrobaeza
pedrobaeza approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-979-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 29bbf47 into OCA:17.0 Dec 4, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1be5f5a. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 17.0-add-icon-base_tier_validation branch December 4, 2024 09:04
@LoisRForgeFlow LoisRForgeFlow mentioned this pull request Dec 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexPForgeFlow @OCA-git-bot @pedrobaeza @LoisRForgeFlow