Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] base_tier_validation: last comment instead of first comment #975

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from
Open

[14.0][FIX] base_tier_validation: last comment instead of first comment #975

wants to merge 1 commit into from

Conversation

mathben
Copy link
Contributor

@mathben mathben commented Dec 2, 2024

  • With multiple approbation, the first comment is repeated into mail.message and propagate wrong message

@OCA-git-bot
Copy link
Contributor

Hi @LoisRForgeFlow,
some modules you are maintaining are being modified, check this out!

@mathben mathben changed the title [FIX] base_tier_validation: last comment instead of first comment [14.0][FIX] base_tier_validation: last comment instead of first comment Dec 2, 2024
@mathben
[FIX] base_tier_validation: last comment instead of first comment
1d11e4c 
- With multiple approbation, the first comment is repeated into
mail.message and propagate wrong message
@mathben mathben force-pushed the 14.0_fix_base_tier_validation_message_repetition branch from 42710ae to 1d11e4c Compare December 2, 2024 22:10
LoisRForgeFlow
LoisRForgeFlow requested changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending to confirm bug (see discussion #978 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathben @OCA-git-bot @LoisRForgeFlow