18.0 mig base tier validation

.pre-commit-config.yaml

@@ -20,6 +20,8 @@ exclude: |
   /tests/samples/.*|
   # You don't usually want a bot to modify your legal texts
   (LICENSE.*|COPYING.*)
+  # Modules
+  ^base_tier_validation/static/src/components/.*$|
 default_language_version:
   python: python3
   node: "22.9.0"

base_tier_validation/README.rst

@@ -17,13 +17,13 @@ Base Tier Validation
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fserver--ux-lightgray.png?logo=github
-    :target: https://github.com/OCA/server-ux/tree/17.0/base_tier_validation
+    :target: https://github.com/OCA/server-ux/tree/18.0/base_tier_validation
     :alt: OCA/server-ux
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation
+    :target: https://translation.odoo-community.org/projects/server-ux-18-0/server-ux-18-0-base_tier_validation
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/server-ux&target_branch=17.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/server-ux&target_branch=18.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -66,16 +66,16 @@ To configure this module, you need to:
 
 **Note:**
 
--  If check *Notify Reviewers on Creation*, all possible reviewers will
-   be notified by email when this definition is triggered.
--  If check *Notify reviewers on reaching pending* if you want to send a
-   notification when pending status is reached. This is usefull in a
-   approve by sequence scenario to only notify reviewers when it is
-   their turn in the sequence.
--  If check *Comment*, reviewers can comment after click Validate or
-   Reject.
--  If check *Approve by sequence*, reviewers is forced to review by
-   specified sequence.
+- If check *Notify Reviewers on Creation*, all possible reviewers will
+  be notified by email when this definition is triggered.
+- If check *Notify reviewers on reaching pending* if you want to send a
+  notification when pending status is reached. This is usefull in a
+  approve by sequence scenario to only notify reviewers when it is their
+  turn in the sequence.
+- If check *Comment*, reviewers can comment after click Validate or
+  Reject.
+- If check *Approve by sequence*, reviewers is forced to review by
+  specified sequence.
 
 To configure Tier Validation Exceptions, you need to:
 
@@ -90,42 +90,40 @@ To configure Tier Validation Exceptions, you need to:
 
 **Note:**
 
--  If you don't create any exception, the Validated record will be
-   readonly and cannot be modified.
--  If check *Write under Validation*, records will be able to be
-   modified only in the defined fields when the Validation process is
-   ongoing.
--  If check *Write after Validation*, records will be able to be
-   modified only in the defined fields when the Validation process is
-   finished.
--  If check *Write after Validation* and *Write under Validation*,
-   records will be able to be modified defined fields always.
+- If you don't create any exception, the Validated record will be
+  readonly and cannot be modified.
+- If check *Write under Validation*, records will be able to be modified
+  only in the defined fields when the Validation process is ongoing.
+- If check *Write after Validation*, records will be able to be modified
+  only in the defined fields when the Validation process is finished.
+- If check *Write after Validation* and *Write under Validation*,
+  records will be able to be modified defined fields always.
 
 Known issues / Roadmap
 ======================
 
 This is the list of known issues for this module. Any proposal for
 improvement will be very valuable.
 
--  **Issue:**
+- **Issue:**
 
-   When using approve_sequence option in any tier.definition there can
-   be inconsistencies in the systray notifications.
+  When using approve_sequence option in any tier.definition there can be
+  inconsistencies in the systray notifications.
 
-   **Description:**
+  **Description:**
 
-   Field can_review in tier.review is used to filter out, in the systray
-   notifications, the reviews a user can approve. This can_review field
-   is updated **in the database** in method review_user_count, this can
-   make it very inconsistent for databases with a lot of users and
-   recurring updates that can change the expected behavior.
+  Field can_review in tier.review is used to filter out, in the systray
+  notifications, the reviews a user can approve. This can_review field
+  is updated **in the database** in method review_user_count, this can
+  make it very inconsistent for databases with a lot of users and
+  recurring updates that can change the expected behavior.
 
--  **Migration to 15.0:**
+- **Migration to 15.0:**
 
-   The parameter \_tier_validation_manual_config will become False, on
-   14.0, the default value is True, as the change is applied after the
-   migration. In order to use the new behavior we need to modify the
-   value on our expected model.
+  The parameter \_tier_validation_manual_config will become False, on
+  14.0, the default value is True, as the change is applied after the
+  migration. In order to use the new behavior we need to modify the
+  value on our expected model.
 
 Changelog
 =========
@@ -147,69 +145,69 @@ Migrated to Odoo 14.
 
 Fixes:
 
--  When using approve_sequence option in any tier.definition there can
-   be inconsistencies in the systray notifications
--  When using approve_sequence, still not approve only the needed
-   sequence, but also other sequence for the same approver
+- When using approve_sequence option in any tier.definition there can be
+  inconsistencies in the systray notifications
+- When using approve_sequence, still not approve only the needed
+  sequence, but also other sequence for the same approver
 
 12.0.3.3.1 (2019-12-02)
 -----------------------
 
 Fixes:
 
--  Show comment on Reviews Table.
--  Edit notification with approve_sequence.
+- Show comment on Reviews Table.
+- Edit notification with approve_sequence.
 
 12.0.3.3.0 (2019-11-27)
 -----------------------
 
 New features:
 
--  Add comment on Reviews Table.
--  Approve by sequence.
+- Add comment on Reviews Table.
+- Approve by sequence.
 
 12.0.3.2.1 (2019-11-26)
 -----------------------
 
 Fixes:
 
--  Remove message_subscribe_users
+- Remove message_subscribe_users
 
 12.0.3.2.0 (2019-11-25)
 -----------------------
 
 New features:
 
--  Notify reviewers
+- Notify reviewers
 
 12.0.3.1.0 (2019-07-08)
 -----------------------
 
 Fixes:
 
--  Singleton error
+- Singleton error
 
 12.0.3.0.0 (2019-12-02)
 -----------------------
 
 Fixes:
 
--  Edit Reviews Table
+- Edit Reviews Table
 
 12.0.2.1.0 (2019-05-29)
 -----------------------
 
 Fixes:
 
--  Edit drop-down style width and position
+- Edit drop-down style width and position
 
 12.0.2.0.0 (2019-05-28)
 -----------------------
 
 New features:
 
--  Pass parameters as functions.
--  Add Systray.
+- Pass parameters as functions.
+- Add Systray.
 
 12.0.1.0.0 (2019-02-18)
 -----------------------
@@ -237,7 +235,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/server-ux/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/server-ux/issues/new?body=module:%20base_tier_validation%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/server-ux/issues/new?body=module:%20base_tier_validation%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -252,24 +250,24 @@ Authors
 Contributors
 ------------
 
--  Lois Rilo <[email protected]>
--  Naglis Jonaitis <[email protected]>
--  Adrià Gil Sorribes <[email protected]>
--  Pimolnat Suntian <[email protected]>
--  Pedro Gonzalez <[email protected]>
--  Kitti U. <[email protected]>
--  Saran Lim. <[email protected]>
--  Carlos Lopez <[email protected]>
--  Javier Colmeiro <[email protected]>
--  bosd
--  Evan Soh <[email protected]>
--  Manuel Regidor <[email protected]>
--  Eduardo de Miguel <[email protected]>
--  `XCG Consulting <https://xcg-consulting.fr>`__:
-
-   -  Houzéfa Abbasbhay
-
--  Stefan Rijnhart <[email protected]>
+- Lois Rilo <[email protected]>
+- Naglis Jonaitis <[email protected]>
+- Adrià Gil Sorribes <[email protected]>
+- Pimolnat Suntian <[email protected]>
+- Pedro Gonzalez <[email protected]>
+- Kitti U. <[email protected]>
+- Saran Lim. <[email protected]>
+- Carlos Lopez <[email protected]>
+- Javier Colmeiro <[email protected]>
+- bosd
+- Evan Soh <[email protected]>
+- Manuel Regidor <[email protected]>
+- Eduardo de Miguel <[email protected]>
+- `XCG Consulting <https://xcg-consulting.fr>`__:
+
+  - Houzéfa Abbasbhay
+
+- Stefan Rijnhart <[email protected]>
 
 Maintainers
 -----------
@@ -292,6 +290,6 @@ Current `maintainer <https://odoo-community.org/page/maintainer-role>`__:
 
 |maintainer-LoisRForgeFlow| 
 
-This module is part of the `OCA/server-ux <https://github.com/OCA/server-ux/tree/17.0/base_tier_validation>`_ project on GitHub.
+This module is part of the `OCA/server-ux <https://github.com/OCA/server-ux/tree/18.0/base_tier_validation>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

base_tier_validation/__manifest__.py

@@ -3,7 +3,7 @@
 {
     "name": "Base Tier Validation",
     "summary": "Implement a validation process based on tiers.",
-    "version": "17.0.2.2.1",
+    "version": "18.0.1.0.0",
     "development_status": "Mature",
     "maintainers": ["LoisRForgeFlow"],
     "category": "Tools",
@@ -26,7 +26,7 @@
     ],
     "assets": {
         "web.assets_backend": [
-            "/base_tier_validation/static/src/components/tier_review_menu/tier_review_menu.esm.js",
+            "/base_tier_validation/static/src/components/tier_review_menu/tier_review_menu.esm.js",  # pylint: disable=no-undef
             "/base_tier_validation/static/src/components/tier_review_menu/tier_review_menu.xml",
             "/base_tier_validation/static/src/components/tier_review_widget/tier_review_widget.esm.js",
             "/base_tier_validation/static/src/components/tier_review_widget/tier_review_widget.scss",

base_tier_validation/models/tier_validation.py

@@ -106,16 +106,16 @@
 
     @api.model
     def _search_can_review(self, operator, value):
         domain = [
             ("review_ids.reviewer_ids", "=", self.env.user.id),
             ("review_ids.status", "in", ["pending", "waiting"]),
             ("review_ids.can_review", "=", True),
             ("rejected", "=", False),
         ]
         if "active" in self._fields:
             domain.append(("active", "in", [True, False]))
         res_ids = self.search(domain).filtered("can_review").ids
         return [("id", "in", res_ids)]
 
     @api.depends("review_ids")
     def _compute_reviewer_ids(self):
@@ -163,21 +163,21 @@
         return self._description
 
     def _get_to_validate_message(self):
-        return (
-            """<i class="fa fa-info-circle" /> %s"""
-            % _("This %s needs to be validated")
-            % self._get_to_validate_message_name()
+        return _(
+            f"""<i class="fa fa-info-circle/> This
+                {self._get_to_validate_message_name()} needs to be validated
+            """
         )
 
     def _get_validated_message(self):
-        msg = """<i class="fa fa-thumbs-up" /> %s""" % _(
-            """Operation has been <b>validated</b>!"""
+        msg = _(
+            """"<i class="fa fa-thumbs-up"/> Operation has been <b>validated</b>!"""
         )
         return self.validated and msg or ""
 
     def _get_rejected_message(self):
-        msg = """<i class="fa fa-thumbs-down" /> %s""" % _(
-            """Operation has been <b>rejected</b>."""
+        msg = _(
+            """<i class="fa fa-thumbs-down"/> Operation has been <b>rejected</b>."""
         )
         return self.rejected and msg or ""
 
@@ -194,21 +194,21 @@
             if item.validated and not item.rejected:
                 item.validation_status = "validated"
             elif not item.validated and item.rejected:
                 item.validation_status = "rejected"
             elif (
                 not item.validated
                 and not item.rejected
                 and any(item.review_ids.filtered(lambda x: x.status == "pending"))
             ):
                 item.validation_status = "pending"
             elif (
                 not item.validated
                 and not item.rejected
                 and any(item.review_ids.filtered(lambda x: x.status == "waiting"))
             ):
                 item.validation_status = "waiting"
             else:
                 item.validation_status = "no"
 
     def _compute_next_review(self):
         for rec in self:
@@ -236,8 +236,8 @@
     def _compute_need_validation(self):
         for rec in self:
             if isinstance(rec.id, models.NewId):
                 rec.need_validation = False
                 continue
             tiers = (
                 self.env["tier.definition"]
                 .with_context(active_test=True)
@@ -258,7 +258,7 @@
             domain = literal_eval(tier.definition_domain)
             return self.filtered_domain(domain)
         else:
             return self
 
     @api.model
     def _get_validation_exceptions(self, extra_domain=None, add_base_exceptions=True):
@@ -329,7 +329,7 @@
             if val not in exceptions:
                 not_allowed_fields.append(val)
         if not not_allowed_fields:
             return []
 
         not_allowed_field_names, allowed_field_names = [], []
         for fld_name, fld_data in self.fields_get(
@@ -349,9 +349,9 @@
 
     def _write(self, vals):
         if self._tier_validation_state_field_is_computed:
             self._tier_validation_check_state_on_write(vals)
             self._tier_validation_check_write_remove_reviews(vals)
         return super()._write(vals)
 
     def _tier_validation_get_current_state_value(self):
         """Get the current value from the cache or the database.
@@ -455,7 +455,7 @@
     def _tier_validation_check_write_remove_reviews(self, vals):
         for rec in self:
             if rec._allow_to_remove_reviews(vals):
                 rec.mapped("review_ids").unlink()
 
     def _allow_to_remove_reviews(self, values):
         """Method for deciding whether the elimination of revisions is necessary."""
@@ -466,10 +466,10 @@
         state_from = self._tier_validation_get_current_state_value()
         # If you change to _cancel_state
         if state_to in (self._cancel_state):
             return True
         # If it is changed to _state_from and it was not in _state_from
         if state_to in self._state_from and state_from not in self._state_from:
             return True
         return False
 
     def _check_state_from_condition(self):
@@ -753,14 +753,17 @@
     @api.model
     def _update_counter(self, review_counter):
         self.review_ids._compute_can_review()
-        notifications = []
         channel = "base.tier.validation/updated"
-        notifications.append([self.env.user.partner_id, channel, review_counter])
-        self.env["bus.bus"]._sendmany(notifications)
+        self.env["bus.bus"]._sendone(
+            channel,
+            "inbox",
+            f"Base tier validation for partner "
+            f"{self.env.user.partner_id}, counter {review_counter}",
+        )
 
     def unlink(self):
         self.mapped("review_ids").unlink()
         return super().unlink()
 
     def _add_tier_validation_buttons(self, node, params):
         str_element = self.env["ir.qweb"]._render(
@@ -820,7 +823,7 @@
             excepted_fields = self._get_all_validation_exceptions()
             for node in doc.xpath("//field[@name][not(ancestor::field)]"):
                 if node.attrib.get("name") in excepted_fields:
                     continue
                 new_r_modifier = self._get_tier_validation_readonly_domain()
                 old_r_modifier = node.attrib.get("readonly")
                 if old_r_modifier:

base_tier_validation/security/ir.model.access.csv

@@ -7,5 +7,5 @@ access_tier_review,access.tier.review,model_tier_review,base.group_user,1,1,1,1
 access_tier_definition_all,tier.definition.all,model_tier_definition,base.group_user,1,0,0,0
 access_tier_definition_settings,tier.definition.settings,model_tier_definition,base.group_system,1,1,1,1
 access_comment_wizard,access.comment.wizard,model_comment_wizard,base.group_user,1,1,1,1
-access_tier_validation_exceptions_all,tier.validation.exceptions,model_tier_validation_exception,,1,0,0,0
+access_tier_validation_exceptions_all,tier.validation.exceptions,model_tier_validation_exception,base.group_user,1,0,0,0
 access_tier_validation_exceptions_settings,tier.validation.exceptions,model_tier_validation_exception,base.group_system,1,1,1,1