[14.0] base_tier_validation_forward: Improve wizard usability #887
Conversation
|
Hi @kittiu, @LoisRForgeFlow, |
* Do not require a comment to forward validation * Restrict possibility to forward to same user
grindtildeath
force-pushed
the
14.0-imp-base_tier_validation_forward
branch
from
1f1252f to
7174641
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
@OCA/tools-maintainers anyone to reopen this please? 🙏 |
|
Hi @LoisRForgeFlow, @kittiu, |
| @@ -101,6 +101,7 @@ def _get_sequences_to_approve(self, user): | |||
| sequences.append(my_sequence) | |||
| return sequences | |||
|
|
|||
| @api.depends_context("uid") | |||
There was a problem hiding this comment.
can you elaborate, why is it a missing decorator?
There was a problem hiding this comment.
forgot to ping you @grindtildeath
There was a problem hiding this comment.
@LoisRForgeFlow It's such a long time ago I don't remember exactly why it was needed. 😞
But if self.env.user is used in the compute function, it means the function still depends on connected user. I guess it could havve been we had some local tests where the value was not recomputed after altering the user, but I cannot tell for sure.
There was a problem hiding this comment.
it is hard for me to approve then. Without steps to reproduce or a description of what's being solved... 😕
github-actions
bot
removed
the
stale
No description provided.