Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Payslip item name in user interface language. #151

Merged
merged 2 commits into from
May 21, 2024
Merged

[FIX] Payslip item name in user interface language. #151

merged 2 commits into from
May 21, 2024

Conversation

kasado
Copy link

@kasado kasado commented May 20, 2024

When computing payslip, generate payslip line name in user interface language.

When computing payslip, generate payslip line name in user interface language.
@OCA-git-bot
Copy link
Contributor

Hi @nimarosa, @appstogrow,
some modules you are maintaining are being modified, check this out!

@kasado kasado marked this pull request as ready for review May 20, 2024 07:55
@kasado
Copy link
Author

kasado commented May 21, 2024

Hi @nimarosa, @appstogrow, some modules you are maintaining are being modified, check this out!

Quick question, could you please review the PR? Just wondering if you are using payroll, have you noticed that payslip items are not translated to user language?

regards
Kasparas

@nimarosa
Copy link
Contributor

Hello @kasado i don't see any changes in code, only a change in one file adding a line break. Please be sure the PR is complete.

@kasado
Copy link
Author

kasado commented May 21, 2024

Hello @kasado i don't see any changes in code, only a change in one file adding a line break. Please be sure the PR is complete.

Hi Nicolas,

Threre are two commits in PR. Please look on the first one a087ea.... Just adding context calling call_kw. Second one commit was simply to split same line, because it failed some pre_submit test.

Regards
Kasparas

@nimarosa
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-151-by-nimarosa-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1cebeff into OCA:15.0 May 21, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a3b6322. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants