[18.0][MIG] l10n_ch_adr_report: Migration to 18.0 #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xaviedoanhduy
force-pushed
the
18.0-mig-l10n_ch_adr_report
branch
2 times, most recently
from
4add359 to
b2f4154
Compare
xaviedoanhduy
force-pushed
the
18.0-mig-l10n_ch_adr_report
branch
from
fa7467b to
d90f377
Compare
xaviedoanhduy
force-pushed
the
18.0-mig-l10n_ch_adr_report
branch
from
d90f377 to
5c9c508
Compare
TDu
reviewed
Oct 18, 2024
Comment on lines
119
to
116
| qty = 0 | ||
| for rec in move_lines: | ||
| if rec.state == "done": | ||
| qty += rec.quantity_done | ||
| else: | ||
| qty += rec.product_uom_qty | ||
| qty = sum(line.quantity for line in move_lines) |
There was a problem hiding this comment.
I am not sure this is correct, because with the change in Odoo core we still have the product_uom_qty field.
I think this
qty = 0
for rec in move_lines:
if rec.picked:
qty += rec.quantity
else:
qty += rec.product_uom_qty
would be better
There was a problem hiding this comment.
thanks @TDu, i see that the use of picked field is not quite like its definition in this case. but maybe i was a bit confused about product_uom_qty so i will restore the original code and just edit quantity to replace the outdated quantity_done
|
Also adding some small unit tests would be a good improvement for this migration |
xaviedoanhduy
force-pushed
the
18.0-mig-l10n_ch_adr_report
branch
4 times, most recently
from
284f106 to
c561375
Compare
By default all moves related to dangerous product are used to generate the report. This PR adds a hook that allow to customize the filtering.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-switzerland-14.0/l10n-switzerland-14.0-l10n_ch_adr_report Translate-URL: https://translation.odoo-community.org/projects/l10n-switzerland-14-0/l10n-switzerland-14-0-l10n_ch_adr_report/
xaviedoanhduy
force-pushed
the
18.0-mig-l10n_ch_adr_report
branch
from
c561375 to
dc044ec
Compare
TDu
approved these changes
Oct 29, 2024
sebalix
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
Note
Result
Swiss Dangerous Goods Report.pdf