Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] hr_course: Migration to 17.0 #1367

Merged
merged 44 commits into from
Aug 7, 2024
Merged

[17.0][MIG] hr_course: Migration to 17.0 #1367

merged 44 commits into from
Aug 7, 2024

Conversation

DorianMAG
Copy link
Contributor

supersedes #1306

Jaime Arroyo and others added 30 commits November 14, 2023 15:44
@manishkumarbohra
[11.0][ADD] hr_course
a4fa72f
@manishkumarbohra
[12.0][MIG] hr_course
dc2b7c7
@manishkumarbohra
[IMP] hr_course: black, isort, prettier
7646093
@manishkumarbohra
[13.0][MIG] hr_course
06b335e
@oca-travis @manishkumarbohra
[UPD] Update hr_course.pot
401faf8
@oca-transbot @manishkumarbohra
Update translation files
61a9fee 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-12.0/hr-12.0-hr_course
Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_course/
@gurneyalex @manishkumarbohra
[IMP] : black, isort, prettier
cdaa14d
@gurneyalex @manishkumarbohra
[MIG] hr_course: migration to 14.0
0409ae1
@FernandoRomera @manishkumarbohra
[REF] hr_course: training plan planning ISO 9001
c4bb6d3
@etobella @manishkumarbohra
[OU-IMP] hr_course: Finish migration (OCA#1)
51bfeb4
@manishkumarbohra
[IMP] hr_course: Add improvements to 14
c929f7c
@olgamarcocb @manishkumarbohra
Translated using Weblate (Spanish)
00cbae5 
Currently translated at 100.0% (89 of 89 strings)

Translation: hr-14.0/hr-14.0-hr_course
Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_course/es/
@marylla @manishkumarbohra
Added translation using Weblate (German)
1f63102
@olgamarcocb @manishkumarbohra
[MIG] hr_course: Migration to 15.0
9bd7f21
@manishkumarbohra
[UPD] Update hr_course.pot
5f8e04b
@OCA-git-bot @manishkumarbohra
[UPD] README.rst
191da9d
@victoralmau @manishkumarbohra
[FIX] hr_course: Remove test folder from __init__
14db5fb
@FernandoRomera @manishkumarbohra
[16.0][MIG] hr_course: Migration to 16.0
3aa0766
@manishkumarbohra
[UPD] Update hr_course.pot
273877e
@OCA-git-bot @manishkumarbohra
[UPD] README.rst
7b16b55
@weblate @manishkumarbohra
Update translation files
6a20dca 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-16.0/hr-16.0-hr_course
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_course/
@victoralmau @manishkumarbohra
[IMP] hr_course: Remove the readonly=True attribute to be able to use…
74641a3 
… the permanence fields.
@victoralmau @manishkumarbohra
[IMP] hr_course: Add Schedules page from course editable to be more u…
c087afc 
…seful
@OCA-git-bot @manishkumarbohra
hr_course 16.0.1.1.0
9c8f8e0
@mymage @manishkumarbohra
Added translation using Weblate (Italian)
c32de61
@mymage @manishkumarbohra
Translated using Weblate (Italian)
3a67c3f 
Currently translated at 100.0% (84 of 84 strings)

Translation: hr-16.0/hr-16.0-hr_course
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_course/it/
@mymage @manishkumarbohra
Translated using Weblate (Italian)
cd7edd5 
Currently translated at 100.0% (84 of 84 strings)

Translation: hr-16.0/hr-16.0-hr_course
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_course/it/
@etobella @manishkumarbohra
[IMP] hr_course: Add internal notes
923e6fc
@francesco-ooops @manishkumarbohra
Translated using Weblate (Italian)
b84bcf3 
Currently translated at 100.0% (84 of 84 strings)

Translation: hr-16.0/hr-16.0-hr_course
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_course/it/
@manishkumarbohra
[UPD] Update hr_course.pot
fbf8915
weblate and others added 7 commits November 14, 2023 15:44
@weblate @manishkumarbohra
Update translation files
d3cce11 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-16.0/hr-16.0-hr_course
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_course/
@mymage @manishkumarbohra
Translated using Weblate (Italian)
85778d6 
Currently translated at 100.0% (86 of 86 strings)

Translation: hr-16.0/hr-16.0-hr_course
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_course/it/
@Ivorra78 @manishkumarbohra
Translated using Weblate (Spanish)
20ebf35 
Currently translated at 100.0% (86 of 86 strings)

Translation: hr-16.0/hr-16.0-hr_course
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_course/es/
@manishkumarbohra
[UPD] Update hr_course.pot
c873dcb
@weblate @manishkumarbohra
Update translation files
bf4276d 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-16.0/hr-16.0-hr_course
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_course/
@manishkumarbohra
[IMP] hr_course: pre-commit auto fixes
7de4774
@manishkumarbohra @DorianMAG
[MIG] hr_course: Migration to 17.0
f6afb5b
flotho
flotho suggested changes Jun 18, 2024
View reviewed changes
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @DorianMAG , looks like it's no more possible to add attendees in session.
this line seems to be responsible https://github.com/OCA/hr/pull/1367/files#diff-62b3dcbd5bf33b0a29e9a3c017fa5b24dcc1fb9cfffbd2e28af9582e8599a7d1R55

could you have a look ?

@DorianMAG DorianMAG force-pushed the 17.0-mig_supersedes-hr_course branch from a55882e to f6afb5b Compare June 19, 2024 09:13
@DorianMAG
Copy link
Contributor Author

thanks @DorianMAG , looks like it's no more possible to add attendees in session. this line seems to be responsible https://github.com/OCA/hr/pull/1367/files#diff-62b3dcbd5bf33b0a29e9a3c017fa5b24dcc1fb9cfffbd2e28af9582e8599a7d1R55

could you have a look ?

Thx for the review,
it's now fix
Regards

@DorianMAG DorianMAG requested a review from flotho June 19, 2024 09:20
flotho
flotho approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functionnal test on runboat
LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@flotho
Copy link
Member

flotho commented Jul 1, 2024

hi @OCA/human-resources-maintainers any chance to have a merge here ?

@FernandoRomera FernandoRomera mentioned this pull request Aug 6, 2024
Closed
pedrobaeza
pedrobaeza approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot migration hr_course
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Aug 7, 2024
@OCA-git-bot
Copy link
Contributor

The migration issue (#1291) has not been updated to reference the current pull request because a previous pull request (#1306) is not closed.
Perhaps you should check that there is no duplicate work.
CC @manishkumarbohra

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1367-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 16dd861 into OCA:17.0 Aug 7, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2ad0382. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza
Copy link
Member

/ocabot migration hr_course

@OCA-git-bot OCA-git-bot mentioned this pull request Aug 7, 2024
Open
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaelTorrecillas gaelTorrecillas gaelTorrecillas approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@flotho flotho flotho approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.