Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] new module magentoerpconnect_transaction_id #183

Open
wants to merge 2 commits into
base: 8.0
Choose a base branch
from

Conversation

lmignon
Copy link

@lmignon lmignon commented Dec 10, 2015

Tests fails due to the payment term used in SetUpMagentoBase

        self.payment_term = self.env.ref('account.'
                                         'account_payment_term_advance')

I've removed the payment_term in the tests developed for this new module and the tests are successful.

from openerp.addons.magentoerpconnect.backend import magento


@magento(replacing=sale.SaleOrderImportMapper)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you read #164 (comment)?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guewen Thank you for the link. I'll introduce a new hook SalePaymentImportMapper to avoid to add a new dependency on base_transaction_id.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guewen done

@lmignon lmignon force-pushed the 8.0-add-magentoerpconnect_transaction_id-lmi branch from 1d72db3 to 83c6304 Compare December 10, 2015 14:11
# Copyright (c) 2015 ACSONE SA/NV (<http://acsone.eu>)
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
{
'name': "magentoerpconnect_transaction_id",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you give it a more friendly name?

@guewen
Copy link
Member

guewen commented Dec 15, 2015

Tests fails due to the payment term used in SetUpMagentoBase

    self.payment_term = self.env.ref('account.'
                                     'account_payment_term_advance')

I've removed the payment_term in the tests developed for this new module and the tests are successful.

What is your status on that?

Tests seem to fail due to a periods error so I guess it is not related to your pull request (openerp.exceptions.RedirectWarning: ('There is no period defined for this date: 2016-01-31.\nPlease go to Configuration/Periods.', 170, 'Go to the configuration panel')).

@Cedric-Pigeon Cedric-Pigeon force-pushed the 8.0-add-magentoerpconnect_transaction_id-lmi branch from 83c6304 to 3537515 Compare April 26, 2017 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants