-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] new module magentoerpconnect_transaction_id #183
base: 8.0
Are you sure you want to change the base?
[ADD] new module magentoerpconnect_transaction_id #183
Conversation
from openerp.addons.magentoerpconnect.backend import magento | ||
|
||
|
||
@magento(replacing=sale.SaleOrderImportMapper) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you read #164 (comment)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guewen Thank you for the link. I'll introduce a new hook SalePaymentImportMapper
to avoid to add a new dependency on base_transaction_id
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guewen done
1d72db3
to
83c6304
Compare
# Copyright (c) 2015 ACSONE SA/NV (<http://acsone.eu>) | ||
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). | ||
{ | ||
'name': "magentoerpconnect_transaction_id", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you give it a more friendly name?
What is your status on that? Tests seem to fail due to a periods error so I guess it is not related to your pull request ( |
83c6304
to
3537515
Compare
Tests fails due to the payment term used in
SetUpMagentoBase
I've removed the payment_term in the tests developed for this new module and the tests are successful.