Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap long lines in code blocks that do not wrap when rendered #205

Open
wants to merge 1 commit into
base: v1.0.0-dev
Choose a base branch
from

Conversation

notEthan
Copy link

In a number of the code blocks you have to scroll right to read long lines. This breaks long lines at 80 columns - not all of them, as URIs, runtime expressions, etc are not wrapped, but where possible.

@kevinduffey
Copy link
Collaborator

@notEthan still working on this?

@notEthan notEthan force-pushed the wrap_long_code_lines branch from 35ebade to 999d4d3 Compare November 20, 2024 20:20
@notEthan notEthan marked this pull request as ready for review November 20, 2024 20:21
@notEthan
Copy link
Author

I don't remember why I marked it as draft but it looks ready to me

kevinduffey
kevinduffey previously approved these changes Nov 20, 2024
Copy link
Collaborator

@kevinduffey kevinduffey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frankkilcommins
Copy link
Collaborator

@notEthan thanks for raising the PR.

Can you target this PR at https://github.com/OAI/Arazzo-Specification/tree/v1.0.0-dev rather than main? We'll be cutting a 1.0.1 release from there.

@notEthan notEthan changed the base branch from main to v1.0.0-dev November 21, 2024 06:24
@notEthan notEthan dismissed kevinduffey’s stale review November 21, 2024 06:24

The base branch was changed.

@notEthan notEthan force-pushed the wrap_long_code_lines branch from 999d4d3 to 0c91d0c Compare November 21, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants