Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add documentation framework and basic docs #239

Merged
merged 6 commits into from
Jul 16, 2024
Merged

Conversation

greg-fer
Copy link
Contributor

@greg-fer greg-fer commented Jul 2, 2024

Added documentation framework files required for publishing. Added basic docs.
NCD-686.

Added documentation framework files required for publishing.
Added basic docs.
NCD-686.

Signed-off-by: Grzegorz Ferenc <[email protected]>
@greg-fer greg-fer added documentation Improvements or additions to documentation. doc required This PR includes user-facing changes that need to be documented. labels Jul 2, 2024
Comment on lines 13 to 51
### Select Device

Dropdown to list the devices attached to the computer. When you select a [supported device](index.md#supported-devices), the app programs the device with the sniffer firmware, and then connects to one of the available serial ports. Sniffing starts automatically.

## After selection

When a device is selected, sniffing in the 2.4 GHz range starts automatically and the side panel options become available.

![RSSI Viewer application window after selecting a device](./screenshots/rssi_viewer_working.gif "RSSI Viewer application window after selecting a device")

### Controls

This side panel area contains buttons that control the sniffing process:

- **Start** and **Pause** - Lets you start or pause the sniffing process.
- **Reset** - Lets you reset the sniffing output.

### Sweep Scan

This option lets you control the frequency with which the sniffing scan are run and with which the results are updated in the **RSSI Viewer** tab.

### Channel Details

The options in this area refer to the Bluetooth Low Energy channels displayed in the **RSSI Viewer** tab.

### Filters

The options in this area allows you to filter out specific Bluetooth LE channels and dBm values in the **RSSI Viewer** tab.
Once you select the values, the sniffing will be performed only within your custom range.

### Device

The **Toggle LED** button lets you toggle the LED on the connected device.

## RSSI Viewer tab

This is the main area of the application where the sniffing results are displayed. Changing the side panel option settings is automatically reflected on the sniffing results when the sniffing is ongoing.

![Chaning RSSI Viewer options during sniffing](./screenshots/rssi_viewer_showcase.gif "Chaning RSSI Viewer options during sniffing")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs review, @kylebonnici . Please answer my questions on chat.

greg-fer added 3 commits July 2, 2024 15:21
Signed-off-by: Grzegorz Ferenc <[email protected]>
Signed-off-by: Grzegorz Ferenc <[email protected]>
Signed-off-by: Grzegorz Ferenc <[email protected]>
Copy link
Contributor

@datenreisender datenreisender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For such a small app the documentation seems almost unnecessary to me.


AFAICS we replicated similar github workflows for zoomin in many projects.

For the label checker we added a generic workflow in shared and then reference that in the projects (example).

How about if we do something similar for zoomin?


You are probably aware that doc/docs/screenshots/rssi_viewer_showcase.gif shows an old version of the app.


You copied resources/screenshot.gif to doc/docs/screenshots/rssi_viewer_showcase.gif. How about removing the former (and adjusting the link in README.md)? And also removing the unused resources/rssi_viewer.jpg?

README.md Outdated
Comment on lines 6 to 7
nRF Connect RSSI Viewer is a tool that shows dBm per frequency in the
2400-2480 MHz range, and allows you to tweak settings like sweep delay and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix the linter issue:

Suggested change
nRF Connect RSSI Viewer is a tool that shows dBm per frequency in the
2400-2480 MHz range, and allows you to tweak settings like sweep delay and
nRF Connect RSSI Viewer is a tool that shows dBm per frequency in the 2400-2480
MHz range, and allows you to tweak settings like sweep delay and animation
duration.

@@ -0,0 +1,12 @@
# nRF Connect RSSI Viewer

nRF Connect RSSI Viewer is a cross-platform tool that shows dBm per frequency in the 2.4 GHz range. It scans the 2400-2480 MHz range, records signal level on particular frequencies, and presents combined results in several ways.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“particular frequencies” and “combined results in several ways” seems a bit wishy-washy to me. How about:

Suggested change
nRF Connect RSSI Viewer is a cross-platform tool that shows dBm per frequency in the 2.4 GHz range. It scans the 2400-2480 MHz range, records signal level on particular frequencies, and presents combined results in several ways.
nRF Connect RSSI Viewer is a cross-platform tool that shows dBm per frequency in the 2.4 GHz range. It scans the 2400-2480 MHz range, records signal level on the Bluetooth Low Energy channel frequencies, and presents the results.

Comment on lines 65 to 71
| Green column | |
| Blue column | |
| Dark blue | |
| Light blue | |
| Dark green | |
| Light green | |
| Numerical value | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need assistance with filling in the meanings here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just gotten the info needed, just need to write it. Thanks for the offer, though!

Signed-off-by: Grzegorz Ferenc <[email protected]>
Copy link
Contributor

@datenreisender datenreisender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

Unless you want to keep it for archaeological reasons, you can also remove resources/rssi_viewer.jpg.

Signed-off-by: Grzegorz Ferenc <[email protected]>
@greg-fer greg-fer merged commit de54e46 into main Jul 16, 2024
4 checks passed
@greg-fer greg-fer deleted the doc_add_framework branch July 16, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc required This PR includes user-facing changes that need to be documented. documentation Improvements or additions to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants