[FEAT] Add option to modify the default configure_optimizers() behavior #1015
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Hey @JQGoh, thanks a lot for trying this approach! Although I think it's fine to add more arguments for now, we can give this a shot when we work towards v2.0. |
In that case, I shall put this on hold then. |
JQGoh
force-pushed
the
feat/modify-config-optimizers
branch
from
3924876 to
eca5d9b
Compare
nbdev_clean --clear_all remove unnecessary changes
JQGoh
force-pushed
the
feat/modify-config-optimizers
branch
from
eca5d9b to
2e3d7c6
Compare
|
@jmoralez @elephaint @marcopeix |
|
This breaking change shall fix #1096 |
lightning by passing the specified function call
| @@ -69,7 +69,7 @@ nbdev_export | |||
| If you're working on the local interface you can just use `nbdev_test --n_workers 1 --do_print --timing`. | |||
|
|
|||
| ### Cleaning notebooks | |||
| Since the notebooks output cells can vary from run to run (even if they produce the same outputs) the notebooks are cleaned before committing them. Please make sure to run `nbdev_clean --clear_all` before committing your changes. If you clean the library's notebooks with this command please backtrack the changes you make to the example notebooks `git checkout nbs/examples`, unless you intend to change the examples. | |||
There was a problem hiding this comment.
Revise this outdated path
|
@jmoralez I have modified it based on your suggestion. |
Rationale
set_configure_optimizersfunction for the BaseModel class such that individual model can overwrite the default configure_optimizers() behavioroptimizerandschedulerto have an effective optimization configuration, otherwise it shall fallback to the default option.This shall deprecate the earlier work introduced in: #998